Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error handle null user attribute better and add use case to test file #290

Merged
merged 3 commits into from
Dec 2, 2022
Merged

fix: Error handle null user attribute better and add use case to test file #290

merged 3 commits into from
Dec 2, 2022

Conversation

mchuangatmp
Copy link
Contributor

@mchuangatmp mchuangatmp commented Dec 1, 2022 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Error handle null user attribute better and add use case to test file
  • Add in dependabot updates
  • Code clean up

Testing Plan

  • Regression tests should pass

Reference Issue

@mchuangatmp mchuangatmp changed the title fix: Error handle null user attribute better and add to test case fix: Error handle null user attribute better and add use case to test file Dec 1, 2022
@mchuangatmp mchuangatmp merged commit 8412478 into development Dec 2, 2022
@mchuangatmp mchuangatmp deleted the fix/SQDSDKS-4891-null branch December 2, 2022 18:02
mparticle-automation added a commit that referenced this pull request Dec 2, 2022
@mparticle-automation
chore: 5.48.3 (release)
fbb2f16 
## [5.48.3](v5.48.2...v5.48.3) (2022-12-02)

### Bug Fixes

* Error handle null user attribute better and add use case to test file ([#290](#290)) ([8412478](8412478))
* Error handle null user attribute value ([#288](#288)) ([73872df](73872df))

### Updates & Maintenance

* Add in ktlintCheck to daily cron job ([#284](#284)) ([1d23a5f](1d23a5f))
* Update submodules ([375b0d3](375b0d3))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.48.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdozor samdozor samdozor approved these changes

@markvdouw markvdouw Awaiting requested review from markvdouw

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchuangatmp @mparticle-automation @samdozor