Implement structured logging #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
jkroepke
commented
May 31, 2023
jkroepke
force-pushed
the
logging
branch
3 times, most recently
from
573b41b
to
c0174ef
Compare
|
@martin-helmich what did you thing about this, after I would rebase this? |
|
rebased |
|
Code Climate has analyzed commit 6dd5899 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
martin-helmich
approved these changes
Jul 15, 2023
There was a problem hiding this comment.
I think I broke this when merging #333; I've resolved the conflicts and all's looking well, so I'll go ahead and merge this one as well. Thanks for your contributions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI,
thanks for you work! This PR implements structured logging. In kubernetes, the json log format can be used and passed to a ELK stack.