Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unix socket for syslog #333

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jun 3, 2023

No description provided.

main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
@martin-helmich martin-helmich self-assigned this Jun 7, 2023
@jkroepke
Copy link
Contributor Author

@martin-helmich please let me know, if I can help here.

@jkroepke
Copy link
Contributor Author

@martin-helmich I would appreciate a review here.

@martin-helmich
Copy link
Owner

Apologies that this has been laying around for a while 🙏 -- I'll give it a look right now.

pkg/syslog/syslog.go Show resolved Hide resolved
main.go Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jul 15, 2023

Code Climate has analyzed commit a4c8835 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

View more on Code Climate.

Copy link
Owner

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 -- I added two additional commits with a new test case, and some refactorings, though

@martin-helmich martin-helmich merged commit 950e9e4 into martin-helmich:master Jul 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants