This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Display pinned messages on a banner at the top of a room #12917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Enhancement
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
a6bb865
to
f341ee2
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
f341ee2
to
23b39af
Compare
Pyaepyae-art
approved these changes
Aug 24, 2024
Pyaepyae-art
approved these changes
Aug 24, 2024
Pyaepyae-art
approved these changes
Aug 24, 2024
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
5c26f96
to
0e3c560
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
0e3c560
to
1f9dde9
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
1f9dde9
to
b5895b4
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
b5895b4
to
6ce4cc8
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
3af777d
to
a7713bf
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
a7713bf
to
595928b
Compare
Pyaepyae-art
approved these changes
Aug 29, 2024
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
a8f359e
to
809790d
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/banner
branch
from
809790d
to
86488a6
Compare
dbkr
reviewed
Aug 29, 2024
| } | ||
|
|
||
| // Handle poll events | ||
| await room.processPollEvents([event]); |
There was a problem hiding this comment.
Hmm, really feels like this is pulling logic out of the js-sdk and duplicating it here. Is there any way we could let the js-sdk do all this work?
There was a problem hiding this comment.
Yeah, I copy pasta this logic from the previous impl of pinning. You are talking about the manual event fetching right?
There was a problem hiding this comment.
@dbkr My proposition is leave this duplication here since the duplication existed before this PR. And I'll make a dedicated PR to move all the ( https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/messages/MPollEndBody.tsx#L41 ) duplicates into the js-sdk.
There was a problem hiding this comment.
Yeah, sounds ideal if you have the time - thank you!
dbkr
approved these changes
Aug 29, 2024
Pyaepyae-art
approved these changes
Aug 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Part of https://github.com/element-hq/element-internal/issues/609
Figma https://www.figma.com/design/nwbnk8RaZctjrrRGTUcx1X/Pinned-Messages?node-id=24-126291&t=21A0TwvtjtfbAidQ-0