Pass all matrix_create_room options through #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's annoying to have to edit each time createRoom gets a new knob. Just pass everything through. There are a couple of related changes to make this work: * in matrix_create_and_join_room, filter out the options which apply to that function before calling matrix_create_room * in local_user_and_room_fixtures, distinguish between opts which are meant for the user fixture and those that are meant for the room fixture - and then update the handful of points which actually pass in such options * the 'publicroomslist' used to pass 'undef' for a couple of parameters to matrix_create_room; that was wrongheaded and we should not pass those params at all.
Merged
erikjohnston
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying to have to edit each time createRoom gets a new knob. Just pass everything through.
There are a couple of related changes to make this work:
in matrix_create_and_join_room, filter out the options which apply to that function before calling matrix_create_room
in local_user_and_room_fixtures, distinguish between opts which are meant for the user fixture and those that are meant for the room fixture - and then update the handful of points which actually pass in such options
the 'publicroomslist' test used to pass 'undef' for a couple of parameters to matrix_create_room; that was wrongheaded and we should not pass those params at all.