Room versioning tests #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/room_versions
branch
from
989d439
to
7a70160
Compare
createRoom now takes a room_version parameter which should set the version of the newly-created room.
Make sure that make_join doesn't let servers without the right support join a room. Also check the room_version field in the result.
richvdh
force-pushed
the
rav/room_versions
branch
from
7a70160
to
aec0990
Compare
erikjohnston
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #482.
Tests for matrix-org/synapse#3654.
See matrix-org/synapse#3654 (comment) for a note on
vdh-test-version.