Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed TransformerDecoder for PyTorch 1.10 #539

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR simply makes transformer-based models of DocTR compatible with the latest PyTorch release.

Any feedback is welcome!

@fg-mindee fg-mindee added module: models Related to doctr.models framework: pytorch Related to PyTorch backend labels Oct 22, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Oct 22, 2021
@fg-mindee fg-mindee self-assigned this Oct 22, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, it is a good thing they added the option!

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #539 (a94d4c4) into main (3c7303c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   95.36%   95.38%   +0.02%     
==========================================
  Files         109      109              
  Lines        4184     4182       -2     
==========================================
- Hits         3990     3989       -1     
+ Misses        194      193       -1     
Flag Coverage Δ
unittests 95.38% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/transformer/pytorch.py 100.00% <ø> (ø)
...dels/detection/differentiable_binarization/base.py 91.82% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49dc156...a94d4c4. Read the comment docs.

@fg-mindee fg-mindee merged commit 323d484 into main Oct 22, 2021
@fg-mindee fg-mindee deleted the transformer-fix branch October 22, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend module: models Related to doctr.models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants