Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize LengthToFee feature #1353

Closed
wants to merge 3 commits into from
Closed

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Mar 16, 2022

What does it do?

This updates Moonbeam runtimes to reflect paritytech/substrate#10785 (currently unmerged).

I'm not able to get this to compile locally (even with overrides in .cargo/config.toml) so it's rather speculative so far.

While the first commit (48a8ed3) provides a minimal no-op change to reflect the above-mentioned PR, the goal of this PR is to overhaul our length-based fees for non-Ethereum transactions. Based on my previous work, this probably means a fee on the order of x^3 (x being transaction length).

That said, this PR will need to be reconciled with #1218.

@notlesh notlesh added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 16, 2022
@notlesh notlesh added the A3-inprogress Pull request is in progress. No review needed at this stage. label Mar 17, 2022
@notlesh
Copy link
Contributor Author

notlesh commented May 12, 2022

Superceded by #1496

@notlesh notlesh closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-inprogress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant