This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Apply WeightToFeePolynomials to pallet_transaction_payment's length fee
#10785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
added
the
A3-in_progress
shawntabrizi
reviewed
Feb 3, 2022
|
seems like a fine change to me |
notlesh
commented
Mar 3, 2022
frame/transaction-payment/src/lib.rs
Outdated
| @@ -536,6 +538,10 @@ where | |||
| } | |||
| } | |||
|
|
|||
| fn length_to_fee(length: u32) -> BalanceOf<T> { | |||
| T::LengthToFee::calc(&(length as u64)) // TODO: saturating / upper bound | |||
There was a problem hiding this comment.
I had left this TODO here because fn weight_to_fee below provides an upper bound.
While I'm not quite sure why it's needed in weight_to_fee, it's guaranteed to be no larger than u32::MAX in the case of length_to_fee, which is likely much smaller than max_block.
Another pair of eyes would be great though.
shawntabrizi
approved these changes
Mar 3, 2022
bkchr
approved these changes
Mar 4, 2022
|
Any update on this, esp. @kianenigma ? |
kianenigma
reviewed
Mar 31, 2022
kianenigma
reviewed
Mar 31, 2022
kianenigma
reviewed
Mar 31, 2022
kianenigma
approved these changes
Mar 31, 2022
kianenigma
added
A8-mergeoncegreen
and removed
A3-in_progress
|
some warnings seem legit, CI will run now. |
|
I'm guessing my polkadot companion PR has CI blocked as well: |
|
My companion polkadot PR is building locally for me. If I'm reading CONTRIBUTING.adoc correctly, I think its CI is expected to be failing at this point. Let me know if I can do anything else to push this along. |
|
I added a It may need CI enabled for me. Thanks :) |
|
bot merge |
acatangiu
pushed a commit
to acatangiu/substrate
that referenced
this pull request
Apr 8, 2022
…th fee (paritytech#10785) * Apply WeightToFeePolynomials to length fee * Remove TransactionByteFee * Add test cases for ConstantModifierFee * Restore import * Use pallet::constant_name * Remove irrelevant TODO comment * Update frame/support/src/weights.rs * Update frame/transaction-payment/src/lib.rs * Update frame/transaction-payment/src/lib.rs * Update frame/transaction-payment/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * s/ConstantModifierFee/ConstantMultiplier/ * Impl LengthToFee for test configs * fmt * Remove unused import * Impl WeightToFeePolynomial for byte fee in ExtBuilder * Remove unused import * fix doc Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2 tasks
8 tasks
10 tasks
10 tasks
3 tasks
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
…th fee (paritytech#10785) * Apply WeightToFeePolynomials to length fee * Remove TransactionByteFee * Add test cases for ConstantModifierFee * Restore import * Use pallet::constant_name * Remove irrelevant TODO comment * Update frame/support/src/weights.rs * Update frame/transaction-payment/src/lib.rs * Update frame/transaction-payment/src/lib.rs * Update frame/transaction-payment/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * s/ConstantModifierFee/ConstantMultiplier/ * Impl LengthToFee for test configs * fmt * Remove unused import * Impl WeightToFeePolynomial for byte fee in ExtBuilder * Remove unused import * fix doc Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…th fee (paritytech#10785) * Apply WeightToFeePolynomials to length fee * Remove TransactionByteFee * Add test cases for ConstantModifierFee * Restore import * Use pallet::constant_name * Remove irrelevant TODO comment * Update frame/support/src/weights.rs * Update frame/transaction-payment/src/lib.rs * Update frame/transaction-payment/src/lib.rs * Update frame/transaction-payment/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * s/ConstantModifierFee/ConstantMultiplier/ * Impl LengthToFee for test configs * fmt * Remove unused import * Impl WeightToFeePolynomial for byte fee in ExtBuilder * Remove unused import * fix doc Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one potential way to address #10784. It adds the same
WeightToFeePolynomialmechanics used for weight fees inpallet_transaction_paymentto length fee. The main goal is to provide more flexibility in charging for transaction size; see the issue for more info on the motivation.This PR would need substantial work, and would probably introduce breaking changes wherever the pallet's config is used.
polkadot companion: paritytech/polkadot#5028
cumulus companion: paritytech/cumulus#1152