Delay contract checks until after all functions are defined #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we might call it with the wrong ABI. This so far wasn't an issue on platforms UniFFI tests on, but can be observed on Windows (at leats in Wine), where suddenly the checksums won't match, e.g. 39784 is expected, but the call gets 33135464 back. The former is 0x9b68 and fits well within a 16-bit unsigned integer. The latter is 0x1f99b68 which does not fit (but it has the same suffix, guess why...)
bendk
reviewed
Jun 21, 2023
bendk
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we might call it with the wrong ABI.
This so far wasn't an issue on platforms UniFFI tests on, but can be observed on Windows (at leats in Wine), where suddenly the checksums won't match, e.g.
39784 is expected, but the call gets 33135464 back. The former is 0x9b68 and fits well within a 16-bit unsigned integer. The latter is 0x1f99b68 which does not fit (but it has the same suffix, guess why...)