Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay contract checks until after all functions are defined #1619

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Delay contract checks until after all functions are defined #1619

merged 1 commit into from
Jun 22, 2023

Commits on Jun 21, 2023

  1. Delay contract checks until after all functions are defined 

    Otherwise we might call it with the wrong ABI.
This so far wasn't an issue on platforms UniFFI tests on,
but can be observed on Windows (at leats in Wine),
where suddenly the checksums won't match, e.g.
39784 is expected, but the call gets 33135464 back.
The former is 0x9b68 and fits well within a 16-bit unsigned integer.
The latter is 0x1f99b68 which does not fit (but it has the same suffix,
guess why...)
    @badboy
    badboy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a8990f1 View commit details
    Browse the repository at this point in the history