Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No null pointer check in CFE_ES_TaskID_ToIndex #1718

Closed
nmullane opened this issue Jul 28, 2021 · 0 comments · Fixed by #1721 or #1701
Closed

No null pointer check in CFE_ES_TaskID_ToIndex #1718

nmullane opened this issue Jul 28, 2021 · 0 comments · Fixed by #1721 or #1701
Assignees
@zanzaben
Labels
enhancement
Milestone
Caelum

Comments

@nmullane
Copy link
Contributor

Describe the bug
CFE_ES_TaskID_ToIndex does not check if the input index pointer is null and will cause a segmentation fault if it is null.

To Reproduce
Steps to reproduce the behavior:

  1. This line in the functional unit tests on my fork will result in a segmentation fault if it is uncommented.
  2. Build CFE and run functional unit tests to view the error.

Expected behavior
CFE_ES_TaskID_ToIndex should return a CFE_ES_BAD_ARGUMENT if the index pointer is null.

System observed on:

  • Hardware: PC
  • OS: Ubuntu 20.04

Reporter Info
Niall Mullane - GSFC 582 Intern
@zanzaben zanzaben self-assigned this Jul 28, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Jul 28, 2021
@zanzaben
Fix nasa#1718, Add null check to CFE_ES_TaskID_ToIndex.
52b719d
@zanzaben zanzaben mentioned this issue Jul 28, 2021
Merged
astrogeco added a commit that referenced this issue Jul 28, 2021
@astrogeco
Merge pull request #1721 from zanzaben/fic1718_TaskID_ToIndex_missing…
28f4792 
…_null_check

Fix #1718, Add null check to CFE_ES_TaskID_ToIndex.
@astrogeco astrogeco mentioned this issue Jul 28, 2021
Merged
paulober pushed a commit to paulober/cFE that referenced this issue Aug 1, 2021
@zanzaben
Fix nasa#1718, Add null check to CFE_ES_TaskID_ToIndex.
bdc9032
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
enhancement
Projects
None yet
Milestone
Caelum
3 participants
@zanzaben @nmullane @skliper