cFE Integration candidate: 2021-07-27 #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests to complete coverage on the following functions: * CFE_ES_RunAppTableScan * CFE_ES_ParseFileEntry * CFE_ES_LoadModule * CFE_ES_CleanUpApp * CFE_ES_CleanupObjectCallback
The return code of CFE_ES_StartAppTask is a CFE status code, so it should be compared to CFE_SUCCESS, not OS_SUCCESS.
Some FS API calls will pass through failure/status codes directly from OSAL without remapping to CFE Status code values. Note this behavior in the documentation and that it will likely change in a future version of CFE.
Fix #1698, correct return code check
Fix #1599, documentation for FS APIs that return OSAL codes
Fix #469, Adding coverage tests for cfe_es_apps.c
Update notes to better clarify that the meta object must persist for the duration of the dump operation, which occurs in another task, so it must not be on the stack. Also update documentation for background even callbacks to better clarify arguments and expectations of the implementation.
Make sure functions documented as CFE status check for CFE_SUCCESS, and functions documented as OSAL status check for OS_SUCCESS.
Add tests for * CFE_TIME_Add * CFE_TIME_Subtract * CFE_TIME_Compare
Fix #1650, Add File Utility Functional Tests.
Fix #1659, Add custom epoch support to TIME UT
Update documentation for all command codes in CFE core apps, in particular the error conditions, to confirm it matches the actual implementation. For common operations that apply to all commmands (length verification) this is now put into the users guide as a general statement rather than repeating the info in every command.
…_null_check Fix #1718, Add null check to CFE_ES_TaskID_ToIndex.
Fix #1396, scrub command documentation
…onal-tests Fix #1689, Add time arithmetic functional tests
Fix #1703, update docs for CFE_FS_BackgroundFileDumpRequest
Fix #1705, correct return code mismatches
astrogeco
changed the title
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 29, 2021
Combines: nasa/cFE#1701, v6.8.0-rc1+dev789 nasa/osal#1116, v5.1.0-rc1+dev578 nasa/cFS-GroundSystem#192, v2.2.0-rc1+dev58 Includes: **cFE** nasa/cFE#1699, correct return code check nasa/cFE#1700, documentation for FS APIs that return OSAL codes nasa/cFE#1695, Adding coverage tests for cfe_es_apps.c nasa/cFE#1673, Add File Utility Functional Tests. nasa/cFE#1711, Add custom epoch support to TIME UT nasa/cFE#1720, Requirements update for Caelum nasa/cFE#1721, Add null check to CFE_ES_TaskID_ToIndex. nasa/cFE#1719, scrub command documentation nasa/cFE#1715, Add time arithmetic functional tests nasa/cFE#1704, update docs for CFE_FS_BackgroundFileDumpRequest nasa/cFE#1706, correct return code mismatches **osal** nasa/osal#1114, Add unit test branch coverage **cFS-GroundSystem** nasa/cFS-GroundSystem#185, Update tlm for ES Blockstats/memstats and TBL HK nasa/cFS-GroundSystem#188, * might be referenced before assignment Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored-by: Niall Mullane <nmullane@users.noreply.github.com> Co-authored-by: Paul <pavll@users.noreply.github.com>
This was referenced Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of nasa/cFS#313
Testing
cFE Checks https://github.com/nasa/cFE/pull/1701/checks
cFS Checks https://github.com/nasa/cFS/pull/313/checks
Authors
@skliper
@jphickey
@zanzaben
@pepepr08
@nmullane
Description
PR #1699
Fix #1698, correct return code check
PR #1700
Fix #1599, documentation for FS APIs that return OSAL codes
PR #1695
Fix #469, Adding coverage tests for cfe_es_apps.c
PR #1673
Fix #1650, Add File Utility Functional Tests.
PR #1711
Fix #1659, Add custom epoch support to TIME UT
PR #1720
Fix #1702 - Re-add CFE_SB_DeletePipe
Fix #1709 - Remove application/child ES registration
Fix #1713 - Remove message initialization clear/no-clear option
Fix #1717 - Add new API requirements to match development changes
Fix #1714 - Remove get message checksum
PR #1721
Fix #1718, Add null check to CFE_ES_TaskID_ToIndex.
PR #1719
Fix #1396, scrub command documentation
PR #1715
Fix #1689, Add time arithmetic functional tests
PR #1704
Fix #1703, update docs for CFE_FS_BackgroundFileDumpRequest
PR #1706
Fix #1705, correct return code mismatches