Fix #146, Support scheduled uplink check #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
jphickey
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Just to confirm -- looks like this will use the existing logic until the first READ_UPLINK_MID is sent, after which it will only forward based on READ_UPLINK_MID reception.
That seems like it should work OK for now. Ideally, CI lab should have a table for this type of config in the future...
dmknutsen
added
CCB:Approved
skliper
force-pushed
the
fix146-consistent_uplink_processing
branch
from
d17cb04
to
9545afa
Compare
|
@dzbaker Rebased and resolved conflicts. I think this should be ready (already approved). |
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Note this took the alternative approach described in #146, just supports scheduling (not a timer and child task).
Testing performed
Built/ran/confirmed nominal behavior
Sent a read uplink request and confirmed expected behavior
Expected behavior changes
None by default, if you send a read uplink request it'll switch to only process packets on request
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC