Fix pointer error in OS_GetErrorName #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
approved these changes
Jan 18, 2024
|
This looks good but I had the question of how it could have been in there for so long and never noticed. We should create a follow-on issue to investigate why this does not fail in our existing workflows |
dzbaker
added
the
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #1435
Testing performed
Build and run all coverage tests including coverage-shared-errors-testrunner on ARM/Linux and PC/Ubunutu. All tests pass and do not seg fault.
Expected behavior changes
Fewer seg faults when running unit tests
System(s) tested on
ARM9/Embedded Linux
PC/Ubuntu 22.04LTS
Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Andrew Hatstat, Geost