Skip to content

Commit

Permalink
fix(push): fix return typing for observables to include undefined (#2907
Browse files Browse the repository at this point in the history
)

BREAKING CHANGE:

BEFORE:

ngrxPush typing doesn't consider `undefined` when the input type is an observable

AFTER:

ngrxPush typing considers `undefined` when the input type is an observable

Closes #2888
  • Loading branch information
samuelfernandez committed Feb 2, 2021
1 parent ba8315f commit abcc599
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/component/src/push/push.pipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class PushPipe<S> implements PipeTransform, OnDestroy {

transform<T>(potentialObservable: null): null;
transform<T>(potentialObservable: undefined): undefined;
transform<T>(potentialObservable: ObservableInput<T>): T;
transform<T>(potentialObservable: ObservableInput<T>): T | undefined;
transform<T>(
potentialObservable: ObservableInput<T> | null | undefined
): T | null | undefined {
Expand Down

0 comments on commit abcc599

Please sign in to comment.