Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(push): fix return typing for observables to include undefined #2907

Merged
merged 1 commit into from
Feb 2, 2021
Merged

fix(push): fix return typing for observables to include undefined #2907

merged 1 commit into from
Feb 2, 2021

Conversation

samuelfernandez
Copy link
Contributor

ngrxPush typing considers undefined when the input type is an observable

Closes #2888

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2888

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Applications that have strict null checks might need to handle undefined.

Other information

ngrxPush typing considers `undefined` when the input type is an observable

Closes #2888
@samuelfernandez
Copy link
Contributor Author

Existing unit tests already account for this scenario and assert that undefined is returned. The only problem was with the typing, which has been fixed.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 1, 2021

Preview docs changes for 0ed5d65 at https://previews.ngrx.io/pr2907-0ed5d65e/

@brandonroberts brandonroberts merged commit abcc599 into ngrx:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngrxPush pipe returns undefined, type is not correct
4 participants