Add CMake build for C++ and scikit-build infrastructure for Python package installation #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th from legate_core target
…re package's config
… instead of cloning
…erent from last time we built
for more information, see https://pre-commit.ci
…net_dir and --conduit flags in case cunumeric builds legate_core instead of finding it
|
@trxcllnt Are the recent changes in CI responsible for the test failure, or is it something else? |
trxcllnt
added
the
category:improvement
|
@marcinz do we need to rebuild the CI images after merging that PR earlier? |
|
So the problem is that we need the modified Github workflow from the conda build PRs. |
manopapad
reviewed
Sep 21, 2022
install.py
Outdated
| if exists(join(legate_dir, "lib", "cmake", "legate_core")): | ||
| cmake_flags += ["-Dlegate_core_ROOT=%s" % legate_dir] | ||
| elif exists(join(legate_dir, "legate_core-config.cmake")): | ||
| if exists(join(legate_dir, "legate_core-config.cmake")): |
There was a problem hiding this comment.
I think just
if legate_dir:
cmake_flags += ["-Dlegate_core_ROOT=%s" % legate_dir]
We'll find out if we did it right once we see how CI works post-merge :-P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of #311 with special branch name so CI will test the legate.core and cunumeric PR's together.