-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake build for C++ and scikit-build infrastructure for Python package installation #514
Merged
Merged
Changes from 1 commit
Commits
Show all changes
184 commits
Select commit
Hold shift + click to select a range
60c5e23
add initial CMake build
trxcllnt 8d568d8
fix compile error
trxcllnt 7224a2d
point to nv-legate repo
trxcllnt 6fda29b
use realm_defines and legion_defines from the build dir if it's defined
trxcllnt 665676d
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt ec74eb4
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 6790c6e
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt fa236e1
update version
trxcllnt e177a8d
guard against RealmRuntime and LegionRuntime targets not existing
trxcllnt 8a826c8
fix version number
trxcllnt 14e2c9e
fully support building without CUDA and OpenMP, detect support for bo…
trxcllnt 63416a4
use compiler cache to speed up tblis builds
trxcllnt 4cbd319
toggle tblis openmp via CUNUMERIC_USE_OPENMP
trxcllnt a5058de
print messages for CI
trxcllnt 1f76d9b
adjust -isystem flag to support clangd
trxcllnt 141d307
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt cdbc3d8
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 843b61e
Toggle CUDA, OpenMP, and bounds checking based on the found legate.co…
trxcllnt 6cbf7e3
print message when legate_core is found
trxcllnt a86db0a
fix typo
trxcllnt 6d2bd14
use CMAKE_SHARED_LIBRARY_SUFFIX for tblis shared library
trxcllnt 2f5b492
remove dot
trxcllnt 244ef17
handle case where build_shared_libs is off
trxcllnt be9f3d2
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 80cbc73
Speed up FetchContent_Populate by downloading a tarball (if possible)…
trxcllnt 8ed6721
cleanup
trxcllnt 9b0e7d1
make required CMake version match conda-forge's CMake
trxcllnt 5c1e78c
Use CPM to find or build OpenBLAS
trxcllnt 51851fc
only create alias targets if OpenBLAS was added
trxcllnt bccfdef
initial commit of CMake-based install.py
trxcllnt 32c1ffb
make install-2.py work with legate build dirs
trxcllnt 6253e9b
place libraries in build/lib
trxcllnt 7f04ef4
add target to preprocess cunumeric_c.h for use with Python CFFI
trxcllnt 9938308
Merge branch 'fea/add-cmake' into fea/install-py-uses-cmake
trxcllnt a370ead
ignore install dir
trxcllnt 19f84f8
use the preprocessed cunumeric_c.h.i generated by CMake instead of do…
trxcllnt 51579ee
remove unused vars
trxcllnt 6fbed41
Merge branch 'fea/add-cmake' into fea/install-py-uses-cmake
trxcllnt d35383c
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt f48ac50
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 6f9c0a8
Merge branch 'fea/add-cmake' into fea/install-py-uses-cmake
trxcllnt d4171cf
fix gitlab archive URI for branches with slashes in the name
trxcllnt 1337bae
update rapids-cmake version
trxcllnt 07e5758
Merge branch 'fea/add-cmake' into fea/install-py-uses-cmake
trxcllnt cdc7902
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e9a3b39
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 167e8a1
Merge branch 'fea/add-cmake' of github.com:trxcllnt/cunumeric into fe…
trxcllnt a352dd3
add scikit-build
trxcllnt 9db95d6
make install.py call pip install .
trxcllnt 8fbe28c
fix lint
trxcllnt eeae89c
remove debugging lines
trxcllnt 800fb99
clean up
trxcllnt c015ae8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ba3d2de
fix default legate branch
trxcllnt 3115798
assume legion_core is already installed in build-install.sh example s…
trxcllnt 548299d
export LIBRARY_PATH if not set
trxcllnt 0e8534b
resolve relative path in build scripts
trxcllnt 48f08a9
formatting
trxcllnt 852849f
apply Bryan's fixes for tests
trxcllnt 143ef38
don't use defaults
trxcllnt 3fdc0bb
fix lint
trxcllnt fbbd4a3
use Readline so tab completion works
trxcllnt fd7ebe1
set CMAKE_BUILD_PARALLEL_LEVEL
trxcllnt 7438060
build tblis on cmake --build instead of cmake configure
trxcllnt ffffd34
fix get_libpath
trxcllnt d03ab1a
fix separate tblis configure/build stages to correctly link to libtbl…
trxcllnt 85c5db2
use add_custom_command so tblis isn't always rebuilt
trxcllnt b75f0d2
use my legate.core branch temporarily in CI
trxcllnt cddc14f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3e84571
default branch and url in install.py temporarily
trxcllnt 7b651fc
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 7f66ca8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0b35b33
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt ad836da
set optimization level -O2
trxcllnt 102461b
Merge branch 'fea/add-cmake' of github.com:trxcllnt/cunumeric into fe…
trxcllnt 2bc4f54
ensure CUDA architectures are detected correctly
trxcllnt c2e6a15
add searchsorted sources
trxcllnt 8884cf3
fix typos
trxcllnt 8476ea8
install tblis if we built it
trxcllnt b0aaa8a
clean out tblis lib and include dirs
trxcllnt 6df103b
use --upgrade instead of --force-install
trxcllnt 1369001
remove todo
trxcllnt 0f34c07
find exact legate_core and cunumeric package versions
trxcllnt d8bb811
do pip install --upgrade if not editable
trxcllnt f927d88
set REQUIRED if legate_core_ROOT is defined
trxcllnt 8443118
Update conda recipe to use CMake
trxcllnt dcf7dab
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 2ff2211
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 42526a8
add new source files
trxcllnt 51f688e
Merge branch 'fea/add-cmake' of github.com:trxcllnt/cunumeric into fe…
trxcllnt 784f644
fix bad merge
trxcllnt ebea196
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 87b92f8
test legate_core_DIR/ROOT for truthy-ness
trxcllnt 7b8c205
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 318ed23
fix lint
trxcllnt e4ffe6e
add back in optional --legate argument to test.py
trxcllnt 51f6367
fix legate_path to be str instead of Path
trxcllnt b25c40c
fix lint
trxcllnt 05bcf8a
move make/cmake/ninja to build requirements
trxcllnt 4cf0b93
add build and runtime dependencies to dev conda envs
trxcllnt 230157e
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt 0e67f09
fix lint
trxcllnt 49a2d6f
remove legion_helpers.cmake
trxcllnt 4c9c585
Enable using tblis_ROOT to find external tblis installations
jjwilke b4805ce
add build and install export sets to rapids_cpm_find
trxcllnt b247d04
Merge pull request #1 from jjwilke/fea/add-cmake
trxcllnt d7376cd
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt b4be507
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1b7444d
add separate build scripts to build with/without prebuilt legate.core
trxcllnt 1fb9263
Merge branch 'fea/add-cmake' of github.com:trxcllnt/cunumeric into fe…
trxcllnt 8ffef20
Merge branch 'branch-22.07' of github.com:nv-legate/cunumeric into fe…
trxcllnt d0c075c
update cunumeric_cpp.cmake for new files
trxcllnt c607011
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2ff0c6a
fix bad merge
trxcllnt 1893816
export tblis_BINARY_DIR to PARENT_SCOPE
trxcllnt 6979771
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
jjwilke ab99e04
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
jjwilke bd3f7b4
do not reference undefined env "_" in tests
jjwilke 895f8f4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 90f7d47
fix tblis flag in install.py
jjwilke ec1a94d
fix flake8 issues on test_patch
jjwilke 931148d
mypy fixes
jjwilke a047586
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
jjwilke 1bf7ef2
Merge pull request #2 from jjwilke/add-cmake-pr
trxcllnt 73d0cfa
update conda-build/build.sh
trxcllnt c44f5e8
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into fe…
trxcllnt c9d9099
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt 3ebd9ac
add initial build directions
jjwilke a49b368
formatting fixes
jjwilke b6e602f
more build information
jjwilke ce1cfc1
add conda directions
jjwilke 7533352
exclude legate files from mypy again
trxcllnt 40226ef
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt 2fec0e4
update default legate core branch and repos
trxcllnt 155172e
ensure sccache is used in conda build
trxcllnt 56513af
allow sccache envvars from external environment
trxcllnt 012b751
ensure SETUPTOOLS_ENABLE_FEATURES is set to "legacy-editable"
trxcllnt d8e27fc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b868dc0
translate gpu name to cuda architectures
trxcllnt 4981b9c
Merge branch 'add-cmake-pr' of github.com:jjwilke/cunumeric into add-…
trxcllnt ca881ac
remove unnecessary cmake define
trxcllnt 12ec0a1
link to curand
trxcllnt 25d1132
fix install.py --with-core arg
trxcllnt 0e5dba0
Apply suggestions from code review
bryevdv 49c85f2
fix gitlab tgz urls
trxcllnt 66e15f4
Apply suggestions from code review
bryevdv 36b5029
don't link curand
trxcllnt f74deb9
use if(POLICY)
trxcllnt cb52b27
Merge branch 'add-cmake-pr' of github.com:jjwilke/cunumeric into add-…
trxcllnt f30c071
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt a03cf93
enable cmake policy 0135
trxcllnt ad1a493
add extra target to update build.ninja mtime so rebuilding doesn't re…
trxcllnt e1fcfd4
remove easy-install.pth
trxcllnt 01bd274
ensure libcunumeric.so is found if installed into a non-standard inst…
trxcllnt 9a1b4be
better handle --prefix flag, remove --python-only flag
trxcllnt 72fcdc7
infer legate_dir from an existing legate.core python install (includi…
trxcllnt d43f765
don't remove easy-install.pth
trxcllnt 4e1c8c9
mirror flags in legate.core example build scripts
trxcllnt f75f787
add argwhere sources
trxcllnt ef7b075
update mypy paths to ignore new location of install_info
trxcllnt c2e64f0
ensure build dir is cleaned if the value of --build-isolation is diff…
trxcllnt 7a1853d
cmake cleanup
trxcllnt 14b152f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e2d35d0
add --max_dim --max_fields --spy --openmp --llvm --hdf --gasnet --gas…
trxcllnt 1ffebb0
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt 7dd9c2b
define CUDAHOSTCXX envvar
trxcllnt 6a6bb31
define flags for debug and minsizerel build types
trxcllnt 84e0665
update package version
trxcllnt 38907a4
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt 3494f1f
parse BUILD_MARCH and/or BUILD_MCPU configuration flags
trxcllnt 1aba142
add openmpi to conda envs
trxcllnt 126f65c
use correct dynamic library extension for other OS's
trxcllnt bcaae19
fix typo
trxcllnt 51217d0
add py.typed for mypy, fix typings
trxcllnt 2a4eef0
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt a93501d
add wrap to sources list
trxcllnt e0a219d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b00791b
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt ebc81f3
remove unused # type: ignore comment
trxcllnt 3486379
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt 7b9cb55
Merge branch 'branch-22.10' of github.com:nv-legate/cunumeric into ad…
trxcllnt 2db9288
Update get_legate_core.cmake
bryevdv 580a396
Update install.py
bryevdv f4cc8fe
Update install.py
bryevdv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just
We'll find out if we did it right once we see how CI works post-merge :-P