shiny: overhaul api for v4 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs work on every non-windows driver, as well as adjustment in window.Window to only include those things all default drivers have.
This is a small api correction to ensure consumers cannot try to send on receive only channels.
set tray icon is still in progress.
SetIcon is much more likely to be a thing a real application will want to call over using tray icons. In addition, there are existing libraries (beeep) that do notifications well already.
Inexpliciably, this appears to do nothing.
this was a failed attempt to make SetIcon work on osx
…le-window and multi-window interfaces
We do not use this and if we ever did, I do not know what we would do with the knowledge that a os level back buffer was preserved or not.
…her packages so graduates out of entities
…her packages so graduates out of entities
Codecov Report
@@ Coverage Diff @@
## release/v4.0.0 #198 +/- ##
==================================================
+ Coverage 91.75% 92.47% +0.71%
==================================================
Files 138 137 -1
Lines 6222 6149 -73
==================================================
- Hits 5709 5686 -23
+ Misses 449 406 -43
+ Partials 64 57 -7
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This was referenced Apr 9, 2022
Feature/v4 shaker+examples
200sc
commented
Apr 9, 2022
|
|
||
| // BUG: this doesn't work, and it doesn't error either | ||
| func (w *Window) SetIcon(img image.Image) error { | ||
| w.window.SetIcon([]image.Image{img}) |
There was a problem hiding this comment.
TODO: the documentation suggests that you can call SetIcon from outside of the main thread, but maybe they are lying? Try sending this through the update window request channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs work on every non-windows driver, as well as adjustment in window.Window to only include those things all default drivers have.