Feature/v4 shaker+examples #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her packages so graduates out of entities
…her packages so graduates out of entities
Codecov Report
@@ Coverage Diff @@
## feature/v4-drivers #202 +/- ##
======================================================
+ Coverage 92.38% 92.40% +0.01%
======================================================
Files 137 137
Lines 6149 6149
======================================================
+ Hits 5681 5682 +1
+ Misses 411 408 -3
- Partials 57 59 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
This should precede #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considered a different space for shaker but current thoughts as follows.
While it is fairly decoupled shaker relies on window and scene so it doesnt make sense in either location but it also doesnt make sense in entities.