Add __optnone__ attribute for Clang #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2018 11:15
…point Thanks to @kiranchandramohan for the suggestion Signed-off-by: Ralph Castain <rhc@open-mpi.org> (cherry picked from commit 5c4185a)
See how the various compilers handle these Signed-off-by: Ralph Castain <rhc@open-mpi.org> (cherry picked from commit db8ebd3)
jsquyres
requested changes
Jan 23, 2018
config/opal_check_attributes.m4
Outdated
|
|
||
| _OPAL_CHECK_SPECIFIC_ATTRIBUTE([extension], | ||
| [ | ||
| #define FOO __extension__ ({size_t bar; bar = 3;}) |
There was a problem hiding this comment.
I do not think that this check does anything. It just tests to see whether #define FOO ... compiles or not, which, since it's just defining a preprocessor macro, will always succeed.
Am I missing something? 🤔
Per https://gcc.gnu.org/onlinedocs/gcc/Alternate-Keywords.html#index-_005f_005fextension_005f_005f, use __extension__ in a C statement that will actually verify if the compiler supports it or not. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit ff31da6)
|
bot:ompi:retest |
1 similar comment
|
bot:ompi:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the optnone attribute to help avoid optimizing out MPIR_Breakpoint
Signed-off-by: Ralph Castain rhc@open-mpi.org