opal_check_attributes: fix __extension__ test #4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://gcc.gnu.org/onlinedocs/gcc/Alternate-Keywords.html#index-_005f_005fextension_005f_005f, use __extension__ in a C statement that will actually verify if the compiler supports it or not. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
|
@bwbarrett I don't see a failure in https://jenkins.open-mpi.org/jenkins/job/open-mpi.pull_request/1981/, but the PRBC CI here at github is claiming failure. Do you know what happened? Is it ok to merge? |
|
@jsquyres for some reason, the Cray build aborted (not failed as in detected an error in the build, but aborted as in something happened to the builder or the build was killed by Jenkins). I can't find any reason for the abort, so it was probably builder going offline for some reason. Looks like it got far enough in the build that this was a success; I'd merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per
https://gcc.gnu.org/onlinedocs/gcc/Alternate-Keywords.html#index-_005f_005fextension_005f_005f,
use extension in a C statement that will actually verify if the
compiler supports it or not.
Signed-off-by: Jeff Squyres jsquyres@cisco.com