Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add +/- comments when both are zero #411

Closed
skearnes opened this issue Sep 29, 2020 · 3 comments · Fixed by #412
Closed

Don't add +/- comments when both are zero #411

skearnes opened this issue Sep 29, 2020 · 3 comments · Fixed by #412
Assignees
Labels
bug Something isn't working submissions Issues related to database submissions

Comments

@skearnes
Copy link
Collaborator

This is confusing since they will be followed up with a more useful comment after the automated update commit. (See open-reaction-database/ord-data#12.)

@skearnes skearnes added bug Something isn't working submissions Issues related to database submissions labels Sep 29, 2020
@skearnes skearnes self-assigned this Sep 29, 2020
@connorcoley
Copy link
Collaborator

Are there ever cases where the change is actually +/- 0 reactions? For example, PRs that just correct an existing entry. Or are these reported as +1/-1?

@skearnes
Copy link
Collaborator Author

There could be (they would be 0/0 and not 1/1), but I think it's more confusing to have the 0/0 comments. I suppose we could do something like only post the comment if process_dataset is running on something in the data/ folder...WDYT?

@connorcoley
Copy link
Collaborator

I think that check would be preferable, since we'll want to keep the real 0/0 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working submissions Issues related to database submissions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants