Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only post a comment if at least one reaction with an ID changed #412

Merged
merged 7 commits into from
Sep 29, 2020
Merged

Only post a comment if at least one reaction with an ID changed #412

merged 7 commits into from
Sep 29, 2020

Conversation

skearnes
Copy link
Collaborator

Fixes #411

@codecov
Copy link

codecov bot commented Sep 29, 2020 •
edited
Loading

Codecov Report

Merging #412 into main will not change coverage.
The diff coverage is 57.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   77.20%   77.20%           
=======================================
  Files          21       21           
  Lines        2264     2264           
  Branches      471      471           
=======================================
  Hits         1748     1748           
  Misses        378      378           
  Partials      138      138
Impacted Files Coverage Δ
ord_schema/process_dataset.py 81.93% <57.14%> (ø)

@skearnes skearnes changed the title Only post a comment if added or removed is nonzero Only post a comment when analyzing files in the data directory Sep 29, 2020
@skearnes
Copy link
Collaborator Author

@connorcoley PTAL

@skearnes
Copy link
Collaborator Author

Oops, broke some tests (good!); I'll comment again when ready.

@skearnes skearnes changed the title Only post a comment when analyzing files in the data directory Only post a comment if at least one reaction with an ID changed Sep 29, 2020
@skearnes
Copy link
Collaborator Author

@connorcoley PTAL; added a "changed" statistic to capture +0/-0.

@skearnes skearnes merged commit 4eda512 into open-reaction-database:main Sep 29, 2020
@skearnes skearnes deleted the zeros branch September 29, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorcoley connorcoley connorcoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't add +/- comments when both are zero
2 participants
@skearnes @connorcoley