configure.ac: update directory space check #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRTE_CANONICALIZE_PATH broke on MacOS when `/usr/bin/python` disappeared (in favor of `/usr/bin/python3`) in MacOS Monterrey. Make things simpler by not canonicalizing the path to begin with. Specifically: just look at `pwd`, $srcdir, and $prefix. Even if $srcdir and/or $prefix are relative to the build dir, the union of all the checks will ensure that none of the target paths will contain spaces. Back-ported from open-mpi/ompi@6992c64 Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
|
Looks like a similar CI failure to #1357 |
|
Does this need to go to any branches? |
|
You are welcome to take it to v2.1 and v2.0, if you have the chance - otherwise, I can pick it up when I do a regular update of those branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRTE_CANONICALIZE_PATH broke on MacOS when
/usr/bin/pythondisappeared (in favor of
/usr/bin/python3) in MacOS Monterrey. Makethings simpler by not canonicalizing the path to begin with.
Specifically: just look at
pwd, $srcdir, and $prefix. Even if$srcdir and/or $prefix are relative to the build dir, the union of all
the checks will ensure that none of the target paths will contain
spaces.
Back-ported from
open-mpi/ompi@6992c64
Signed-off-by: Jeff Squyres jsquyres@cisco.com