Optimize the file descriptor cleanup on OSX #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Bosilca <bosilca@icl.utk.edu> Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
|
Should I also bring this to the v2.0 and v2.1 branches? (per #1359 (comment)) |
|
Not right now - I'm working to update those branches and will pick this up then. |
|
Just curious - how do you wind up building/using the ALPS module under OSX??? |
|
Frack -- I didn't notice that this was on the alps module. 😱 This should have been on the default module. Blarg. I'll make a new PR. |
|
Actually, even worse -- this isn't needed in the odls default module because it uses pmix_close_file_descriptors(). So this PR just should be reverted. Sorry -- I just took the patch and filed the PR, and didn't pay close attention. 👎 |
|
No worries - I should have looked more closely at the target location and realized it was ALPS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: George Bosilca bosilca@icl.utk.edu
Signed-off-by: Jeff Squyres jsquyres@cisco.com