Fixes for endpoint flush #3054
Fixes for endpoint flush #3054
Conversation
|
Test FAILed. |
|
Test FAILed. |
yosefe
force-pushed
the
topic/flush-fixes
branch
from
0924607
to
caa545e
Compare
|
Test PASSed. |
|
Test FAILed. |
We must not update cached tail in uct_mm_ep_flush() if there are any pending elements. We may get new send resources but not use them, so flush could return UCS_OK while there pending requests. Fixes openucx#3052
- Ignore remote completions in case of forced flush (CLOSE_MODE_CANCEL) - The UCP_EP_FLAG_FLUSH_STATE_VALID flag can't be used because it's not valid in release mode. Instead, use the UCP_EP_FLAG_DEST_EP flag as an indirect indication that we may have some operations which wait for software rma/amo completion. - Fix missing initializion of flush state in case of client/server connection establishment with p2p lanes and *without* pre-request.
yosefe
force-pushed
the
topic/flush-fixes
branch
from
caa545e
to
3592e83
Compare
|
Test PASSed. |
|
Test FAILed. |
|
Test PASSed. |
|
@brminich @evgeny-leksikov pls take a look |
src/ucp/rma/flush.c
Outdated
| ucs_queue_push(&flush_state->reqs, &req->send.flush.queue); | ||
| ucs_trace_req("added flush request %p to ep remote completion queue" | ||
| " with sn %d", req, req->send.flush.cmpl_sn); | ||
| /* All pending requires were sent, so 'send_sn' value is up-to-date */ |
There was a problem hiding this comment.
minor: requires->requests
|
Test PASSed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
No description provided.