Fixes for endpoint flush - v1.5.x #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must not update cached tail in uct_mm_ep_flush() if there are any pending elements. We may get new send resources but not use them, so flush could return UCS_OK while there pending requests. Fixes openucx#3052
- Ignore remote completions in case of forced flush (CLOSE_MODE_CANCEL) - The UCP_EP_FLAG_FLUSH_STATE_VALID flag can't be used because it's not valid in release mode. Instead, use the UCP_EP_FLAG_DEST_EP flag as an indirect indication that we may have some operations which wait for software rma/amo completion. - Fix missing initializion of flush state in case of client/server connection establishment with p2p lanes and *without* pre-request.
|
Test PASSed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked from #3054
Fixes #3063
(#3058 was supposed to be for v1.5.x, but it was based on master by mistake)