-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCP/TEST: Fix simultaneous ep close with ucp_hello_world #7224
Merged
yosefe
merged 1 commit into
openucx:master
from
yosefe:topic/tcp-test-fix-simultaneous-ep-close-with
Aug 17, 2021
Merged
TCP/TEST: Fix simultaneous ep close with ucp_hello_world #7224
yosefe
merged 1 commit into
openucx:master
from
yosefe:topic/tcp-test-fix-simultaneous-ep-close-with
Aug 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
force-pushed
the
topic/tcp-test-fix-simultaneous-ep-close-with
branch
2 times, most recently
from
August 11, 2021 22:33
4e06533
to
6956fc9
Compare
@dmitrygx @evgeny-leksikov can you pls take a look? |
yosefe
force-pushed
the
topic/tcp-test-fix-simultaneous-ep-close-with
branch
from
August 11, 2021 23:59
6956fc9
to
7ff8a89
Compare
evgeny-leksikov
approved these changes
Aug 12, 2021
dmitrygx
approved these changes
Aug 12, 2021
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
yosefe
force-pushed
the
topic/tcp-test-fix-simultaneous-ep-close-with
branch
from
August 13, 2021 11:56
357a650
to
68de674
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@hoopoepg can you pls review latest commit ? i saw you added this line but maybe there was another intention i missed |
yosefe
force-pushed
the
topic/tcp-test-fix-simultaneous-ep-close-with
branch
from
August 16, 2021 21:05
2ffd517
to
58407ae
Compare
hoopoepg
approved these changes
Aug 17, 2021
dmitrygx
approved these changes
Aug 17, 2021
bot:pipe:retest |
yosefe
force-pushed
the
topic/tcp-test-fix-simultaneous-ep-close-with
branch
from
August 17, 2021 07:50
9d9d0ea
to
097e250
Compare
Fixes an assertion failure when running ucp_hello_world over TCP transport. UCP: When both sides close their TCP endpoints, one side can receive connection reset event while it's trying to close-flush its endpoint. We should not try to invoke user error callback in such case. Instead, the close operation should complete with status CONNECTION_RESET. UCT/TCP: Need to purge outstanding PUT operations when getting an error. Test: Run ucp_hello_world over several transports. Currently it used TCP only when ran inside a docker, so issue was not detected. Fix barrier in hello_world test to prevent failures.
yosefe
force-pushed
the
topic/tcp-test-fix-simultaneous-ep-close-with
branch
from
August 17, 2021 15:50
097e250
to
f7a4757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As a result of #7140, ucp_hello_world fails in docker when it uses TCP transport, like this:
(https://dev.azure.com/ucfconsort/0b36e3f0-8ab9-4a48-b68b-4b2350e02c88/_apis/build/builds/22781/logs/389)
How