TCP/TEST: Fix simultaneous ep close with ucp_hello_world - v1.11.x #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an assertion failure when running ucp_hello_world over TCP transport. UCP: When both sides close their TCP endpoints, one side can receive connection reset event while it's trying to close-flush its endpoint. We should not try to invoke user error callback in such case. Instead, the close operation should complete with status CONNECTION_RESET. UCT/TCP: Need to purge outstanding PUT operations when getting an error. Test: Run ucp_hello_world over several transports. Currently it used TCP only when ran inside a docker, so issue was not detected. Fix barrier in hello_world test to prevent failures.
yosefe
changed the title
dmitrygx
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Backport #7224
No conflicts, except didn't port a whitespace fix in ucp_ep.c since it's in a function that does not exist in v1.11.x