GTEST/ROCM and UCM/ROCM: fixes for the v1.13 release #8330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0b6a34d)
provide an implementation of estimate_performance for the internal ops. This helps pass a test in the gtest suite. (cherry picked from commit b38c71e)
Delay the memtype detection to rocm md. Otherwise the code path for the detection of rocm between ucm/rocm and uct/rocm can easily diverge and lead to unintended consequences. Fixes an issue observed with a testcase on rocm 5.1 with older linux kernels. (cherry picked from commit cfb0466)
yosefe
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr brings a couple of fixes for the rocm components from master to the v1.13 branch
Specifically:
GTEST/UCM/ROCM: Fix is_rocm_managed_supported gtest
(cherry picked from commit a049c27)
UCT/ROCM/COPY: implement estimate_perf function
(cherry picked form commit 21ca904)
UCM/ROCM: delay memtype detection to md's
(cherry picked from commit ee3aee9)
Why ?
fixes existing issues and makes rocm gtests pass.