Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTEST/ROCM and UCM/ROCM: fixes for the v1.13 release #8330

Merged
merged 3 commits into from
Jun 21, 2022
Merged

GTEST/ROCM and UCM/ROCM: fixes for the v1.13 release #8330

merged 3 commits into from
Jun 21, 2022

Commits on Jun 20, 2022

  1. GTEST/UCM/ROCM: Fix is_rocm_managed_supported gtest 

    (cherry picked from commit 0b6a34d)
    @akolliasAMD @edgargabriel
    akolliasAMD authored and edgargabriel committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    a049c27 View commit details
    Browse the repository at this point in the history

  2. UCT/ROCM/COPY: implement estimate_perf function 

    provide an implementation of estimate_performance for the internal ops.
This helps pass a test in the gtest suite.

(cherry picked from commit b38c71e)
    @edgargabriel
    edgargabriel committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    21ca904 View commit details
    Browse the repository at this point in the history

  3. UCM/ROCM: delay memtype detection to md's 

    Delay the memtype detection to rocm md. Otherwise
the code path for the detection of rocm between
ucm/rocm and uct/rocm can easily diverge and lead to unintended
consequences.

Fixes an issue observed with a testcase on rocm 5.1 with older linux kernels.

(cherry picked from commit cfb0466)
    @edgargabriel
    edgargabriel committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    ee3aee9 View commit details
    Browse the repository at this point in the history