UCT/UCP: Fix compilation errors with armcc-22.1 #8970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhmets
previously approved these changes
Mar 27, 2023
brminich
force-pushed
the
ucp_uct/fix_arm_comp_error
branch
from
397dada
to
998fcca
Compare
|
Verified compilation - PASSED. |
yosefe
reviewed
Apr 2, 2023
Comment on lines
+74
to
+76
| #if !HAVE_DECL_IBV_ACCESS_ON_DEMAND | ||
| # define IBV_ACCESS_ON_DEMAND 0 | ||
| #endif |
There was a problem hiding this comment.
why needed? can't we remove it from the code?
There was a problem hiding this comment.
Can you pls elaborate?
Avoiding compilation failure with arm clang on specific config
There was a problem hiding this comment.
right..
so, maybe we need to expose from UCT that ODP is disabled if IBV_ACCESS_ON_DEMAND==0?
even if it's supported by FW
@Al3xR01 FYI |
|
|
|
We can add arm22 to ci once we add arm platform support. |
brminich
force-pushed
the
ucp_uct/fix_arm_comp_error
branch
from
ff7f6aa
to
a84db69
Compare
yosefe
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix compilation errors with armclang-22.1