AZP/RELEASE: Add ARM release - Part #2 #8895
Conversation
Alexey-Rivkin
force-pushed
the
topic/arm_release-part2
branch
3 times, most recently
from
0c501ef
to
ccfef0f
Compare
Alexey-Rivkin
force-pushed
the
topic/arm_release-part2
branch
4 times, most recently
from
8dbb5b1
to
3214713
Compare
|
@yosefe please, review |
buildlib/az-distro-release.yml
Outdated
| build_container: centos7_cuda11_x86_64 | ||
| artifact_name: $(POSTFIX)-centos7-mofed5-cuda11-x86_64.tar.bz2 |
There was a problem hiding this comment.
can we do something like
build_container: centos7_cuda11_${{ parameters.name }}
artifact_name: $(POSTFIX)-centos7-mofed5-cuda11-${{ parameters.name }}.tar.bz2
in order to avoid ${{ if eq(parameters.name, 'x86_64') }}:
There was a problem hiding this comment.
No, it will cause duplicate key names:
build_container: centos7_cuda11_${{ parameters.name }} # x86_64
build_container: centos7_cuda11_${{ parameters.name }} # aarch64
There was a problem hiding this comment.
It will fail on Azure YAML schema validation.
There was a problem hiding this comment.
why? container name cannot be parametrized?
There was a problem hiding this comment.
Azure limitations. Here I tested it:
#9016
https://dev.azure.com/ucfconsort/ucx/_build/results?buildId=61588
There was a problem hiding this comment.
centos8_cuda11_${{ parameters.name }}: is really listed twice in the file.
Can you try to remove this duplication?
There was a problem hiding this comment.
Right, those dups might be removed. Yet, we have a different set of containers per OS architecture.
We can either reduce the support matrix or separate container lists by if.
There was a problem hiding this comment.
maybe first list all common containers, and then list specific containers under "if" condition?
There was a problem hiding this comment.
This will work!
There was a problem hiding this comment.
Addressed by the latest commit + changed the key name to better reflect expected values.
Alexey-Rivkin
force-pushed
the
topic/arm_release-part2
branch
from
afe7526
to
1c6f7de
Compare
buildlib/az-distro-release.yml
Outdated
| - job: distro_release | ||
| displayName: distro | ||
| - job: distro_release_${{ parameters.arch }} | ||
| displayName: Distro ${{ parameters.arch }} |
There was a problem hiding this comment.
Currently, the job title appears as Distro aarch64 ubuntu20_cuda11_aarch64
Can we rename it to just "ubuntu20_cuda11_aarch64" or similar?
There was a problem hiding this comment.
Close enough?
There was a problem hiding this comment.
Maybe set job name to "Build" or "Distro" - instead of parameters.arch?
There was a problem hiding this comment.
Much better indeed
Alexey-Rivkin
force-pushed
the
topic/arm_release-part2
branch
6 times, most recently
from
c3d7d04
to
f8c7102
Compare
Alexey-Rivkin
force-pushed
the
topic/arm_release-part2
branch
from
f8c7102
to
75776a4
Compare
|
squashed |
What
Build and release ARM-based artifacts.
Part 2: Build DEB/RPM artifacts on ARM.
Why ?
#8762