Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCS/SYS/TOPO: Added bw estimation for Sapphire Rapids family - v1.15.x #9318

Merged
merged 1 commit into from
Aug 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions src/tools/info/sys_info.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,22 @@


static const char *cpu_model_names[] = {
[UCS_CPU_MODEL_UNKNOWN] = "unknown",
[UCS_CPU_MODEL_INTEL_IVYBRIDGE] = "IvyBridge",
[UCS_CPU_MODEL_INTEL_SANDYBRIDGE] = "SandyBridge",
[UCS_CPU_MODEL_INTEL_NEHALEM] = "Nehalem",
[UCS_CPU_MODEL_INTEL_WESTMERE] = "Westmere",
[UCS_CPU_MODEL_INTEL_HASWELL] = "Haswell",
[UCS_CPU_MODEL_INTEL_BROADWELL] = "Broadwell",
[UCS_CPU_MODEL_INTEL_SKYLAKE] = "Skylake",
[UCS_CPU_MODEL_ARM_AARCH64] = "ARM 64-bit",
[UCS_CPU_MODEL_AMD_NAPLES] = "Naples",
[UCS_CPU_MODEL_AMD_ROME] = "Rome",
[UCS_CPU_MODEL_AMD_MILAN] = "Milan",
[UCS_CPU_MODEL_ZHAOXIN_ZHANGJIANG] = "Zhangjiang",
[UCS_CPU_MODEL_ZHAOXIN_WUDAOKOU] = "Wudaokou",
[UCS_CPU_MODEL_ZHAOXIN_LUJIAZUI] = "Lujiazui"
[UCS_CPU_MODEL_UNKNOWN] = "unknown",
[UCS_CPU_MODEL_INTEL_IVYBRIDGE] = "IvyBridge",
[UCS_CPU_MODEL_INTEL_SANDYBRIDGE] = "SandyBridge",
[UCS_CPU_MODEL_INTEL_NEHALEM] = "Nehalem",
[UCS_CPU_MODEL_INTEL_WESTMERE] = "Westmere",
[UCS_CPU_MODEL_INTEL_HASWELL] = "Haswell",
[UCS_CPU_MODEL_INTEL_BROADWELL] = "Broadwell",
[UCS_CPU_MODEL_INTEL_SKYLAKE] = "Skylake",
[UCS_CPU_MODEL_INTEL_SAPPHIRERAPIDS] = "SapphireRapids",
[UCS_CPU_MODEL_ARM_AARCH64] = "ARM 64-bit",
[UCS_CPU_MODEL_AMD_NAPLES] = "Naples",
[UCS_CPU_MODEL_AMD_ROME] = "Rome",
[UCS_CPU_MODEL_AMD_MILAN] = "Milan",
[UCS_CPU_MODEL_ZHAOXIN_ZHANGJIANG] = "Zhangjiang",
[UCS_CPU_MODEL_ZHAOXIN_WUDAOKOU] = "Wudaokou",
[UCS_CPU_MODEL_ZHAOXIN_LUJIAZUI] = "Lujiazui"
};

static const char* cpu_vendor_names[] = {
Expand Down
1 change: 1 addition & 0 deletions src/ucs/arch/cpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ typedef enum ucs_cpu_model {
UCS_CPU_MODEL_INTEL_HASWELL,
UCS_CPU_MODEL_INTEL_BROADWELL,
UCS_CPU_MODEL_INTEL_SKYLAKE,
UCS_CPU_MODEL_INTEL_SAPPHIRERAPIDS,
UCS_CPU_MODEL_ARM_AARCH64,
UCS_CPU_MODEL_AMD_NAPLES,
UCS_CPU_MODEL_AMD_ROME,
Expand Down
3 changes: 3 additions & 0 deletions src/ucs/arch/x86_64/cpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,9 @@ ucs_cpu_model_t ucs_arch_get_cpu_model()
case 0x55:
cpu_model = UCS_CPU_MODEL_INTEL_SKYLAKE;
break;
case 0x8f:
cpu_model = UCS_CPU_MODEL_INTEL_SAPPHIRERAPIDS;
break;
}
break;
/* AMD Zen2 */
Expand Down
3 changes: 3 additions & 0 deletions src/ucs/sys/topo/base/topo.c
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,9 @@ static void ucs_topo_sys_root_distance(ucs_sys_dev_distance_t *distance)
{
distance->latency = 500e-9;
switch (ucs_arch_get_cpu_model()) {
case UCS_CPU_MODEL_INTEL_SAPPHIRERAPIDS:
distance->bandwidth = 23288 * UCS_MBYTE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you get this number?

Copy link
Collaborator Author

@rakhmets rakhmets Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value is copied from the issue. This is a value of bandwidth for message size 262144 obtained by osu_bw benchmark.

break;
case UCS_CPU_MODEL_AMD_ROME:
case UCS_CPU_MODEL_AMD_MILAN:
distance->bandwidth = 5100 * UCS_MBYTE;
Expand Down
Loading