UCS/SYS/TOPO: Added bw estimation for Sapphire Rapids family - v1.15.x #9318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhmets
changed the title
brminich
previously approved these changes
Aug 28, 2023
ivankochin
reviewed
Aug 28, 2023
| @@ -308,6 +308,9 @@ static void ucs_topo_sys_root_distance(ucs_sys_dev_distance_t *distance) | |||
| { | |||
| distance->latency = 500e-9; | |||
| switch (ucs_arch_get_cpu_model()) { | |||
| case UCS_CPU_MODEL_INTEL_SAPPHIRERAPIDS: | |||
| distance->bandwidth = 23288 * UCS_MBYTE; | |||
There was a problem hiding this comment.
How did you get this number?
There was a problem hiding this comment.
The value is copied from the issue. This is a value of bandwidth for message size 262144 obtained by osu_bw benchmark.
ivankochin
previously approved these changes
Aug 28, 2023
yosefe
previously approved these changes
Aug 28, 2023
|
Minor: It seems like we need to update this table too https://github.com/openucx/ucx/blob/master/src/tools/info/sys_info.c#L25 |
rakhmets
dismissed stale reviews from yosefe, ivankochin, and brminich
via
13c0ecb
rakhmets
force-pushed
the
topic/issue_9287_1.15.x
branch
from
6355d7c
to
13c0ecb
Compare
Done. Also squashed commits because of the changes are minor. |
This was referenced Aug 29, 2023
yosefe
approved these changes
Aug 29, 2023
brminich
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added estimation of bandwidth for Intel Sapphire Rapids family.
Why ?
To avoid TCP lane selection instead of IB lanes.
#9287