Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOLS/INFO: Add Icelake CPU model name #9324

Merged
merged 1 commit into from
Sep 2, 2023
Merged

TOOLS/INFO: Add Icelake CPU model name #9324

merged 1 commit into from
Sep 2, 2023

Conversation

ivankochin
Copy link
Contributor

What

Define ucx_info name for Icelake CPUs.

@ivankochin ivankochin self-assigned this Aug 29, 2023
rakhmets
rakhmets previously approved these changes Aug 29, 2023
View reviewed changes
yosefe
yosefe reviewed Aug 29, 2023
View reviewed changes
src/tools/info/sys_info.c
@@ -31,6 +31,7 @@ static const char *cpu_model_names[] = {
[UCS_CPU_MODEL_INTEL_HASWELL] = "Haswell",
[UCS_CPU_MODEL_INTEL_BROADWELL] = "Broadwell",
[UCS_CPU_MODEL_INTEL_SKYLAKE] = "Skylake",
[UCS_CPU_MODEL_INTEL_ICELAKE] = "Icelake",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we also add sapphire rapids?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UCS_CPU_MODEL_INTEL_SAPPHIRERAPIDS hasn't been added to master branch yet.
Should we add Sapphire Rapids in this PR? Or is it better to cherry-pick the commit from 1.15.x branch after merging #9318?

@rakhmets
Copy link
Collaborator

Please extend the condition

ucx/src/ucs/arch/x86_64/cpu.c

Line 457 in ae71b01

case 0x6a:
by adding 0x6e, 0x7e

@ivankochin
Copy link
Contributor Author

Please extend the condition

ucx/src/ucs/arch/x86_64/cpu.c

Line 457 in ae71b01

case 0x6a:

by adding 0x6e, 0x7e

Are you sure about that? Wikichip contains information only about 0x6a for IceLake server chips and 0x7e for client ones.

@rakhmets
Copy link
Collaborator

Please extend the condition

ucx/src/ucs/arch/x86_64/cpu.c

Line 457 in ae71b01

case 0x6a:

by adding 0x6e, 0x7e

Are you sure about that? Wikichip contains information only about 0x6a for IceLake server chips and 0x7e for client ones.

Sorry, 0x6c, not 0x6e.
Please found the codes here https://en.wikichip.org/wiki/intel/cpuid.

CPU Model Code
Ice Lake (client) 0x7e
Ice Lake (server) DE 0x6c
Ice Lake (server) SP 0x6a

We use all model codes to detect other Intel CPU model, e.g. Skylake.

@ivankochin
Copy link
Contributor Author

Please extend the condition

ucx/src/ucs/arch/x86_64/cpu.c

Line 457 in ae71b01

case 0x6a:

by adding 0x6e, 0x7e

Are you sure about that? Wikichip contains information only about 0x6a for IceLake server chips and 0x7e for client ones.

Sorry, 0x6c, not 0x6e. Please found the codes here https://en.wikichip.org/wiki/intel/cpuid.

CPU Model Code
Ice Lake (client) 0x7e
Ice Lake (server) DE 0x6c
Ice Lake (server) SP 0x6a
We use all model codes to detect other Intel CPU model, e.g. Skylake.

Good catch :) done.

@ivankochin ivankochin force-pushed the tools/info/add-icelake-model-name branch from 37d9af1 to d1cf910 Compare August 31, 2023 08:23
@ivankochin
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s), but failed to run 1 pipeline(s).

@ivankochin ivankochin merged commit 47a03db into master Sep 2, 2023
117 checks passed
@rakhmets rakhmets deleted the tools/info/add-icelake-model-name branch October 11, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe approved these changes

@rakhmets rakhmets rakhmets approved these changes

Assignees

@ivankochin ivankochin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivankochin @rakhmets @yosefe