Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOLS/INFO: Add Icelake CPU model name #9324

Merged
merged 1 commit into from
Sep 2, 2023
Merged

TOOLS/INFO: Add Icelake CPU model name #9324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/tools/info/sys_info.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ static const char *cpu_model_names[] = {
[UCS_CPU_MODEL_INTEL_HASWELL] = "Haswell",
[UCS_CPU_MODEL_INTEL_BROADWELL] = "Broadwell",
[UCS_CPU_MODEL_INTEL_SKYLAKE] = "Skylake",
[UCS_CPU_MODEL_INTEL_ICELAKE] = "Icelake",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we also add sapphire rapids?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UCS_CPU_MODEL_INTEL_SAPPHIRERAPIDS hasn't been added to master branch yet.
Should we add Sapphire Rapids in this PR? Or is it better to cherry-pick the commit from 1.15.x branch after merging #9318?

[UCS_CPU_MODEL_ARM_AARCH64] = "ARM 64-bit",
[UCS_CPU_MODEL_AMD_NAPLES] = "Naples",
[UCS_CPU_MODEL_AMD_ROME] = "Rome",
Expand Down
2 changes: 2 additions & 0 deletions src/ucs/arch/x86_64/cpu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,8 @@ ucs_cpu_model_t ucs_arch_get_cpu_model()
cpu_model = UCS_CPU_MODEL_INTEL_SKYLAKE;
break;
case 0x6a:
case 0x6c:
case 0x7e:
cpu_model = UCS_CPU_MODEL_INTEL_ICELAKE;
break;
}
Expand Down
Loading