Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation tracking issue for pallet-xcm execute and send #3771

Open
2 of 7 tasks
franciscoaguirre opened this issue Mar 20, 2024 · 2 comments
Open
2 of 7 tasks

Deprecation tracking issue for pallet-xcm execute and send #3771

franciscoaguirre opened this issue Mar 20, 2024 · 2 comments
Assignees
@franciscoaguirre
Labels
T13-deprecation The current issue/pr is, or should be, part of a deprecation process.

Comments

@franciscoaguirre
Copy link
Contributor

franciscoaguirre commented Mar 20, 2024 •
edited
Loading

@franciscoaguirre franciscoaguirre added the T13-deprecation The current issue/pr is, or should be, part of a deprecation process. label Mar 20, 2024
@franciscoaguirre franciscoaguirre self-assigned this Mar 20, 2024
@franciscoaguirre franciscoaguirre mentioned this issue Mar 20, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
@franciscoaguirre @pgherveou @acatangiu
pallet-xcm: Deprecate execute and send in favor of execute_blob…
feee773 
… and `send_blob` (#3749)

`execute` and `send` try to decode the xcm in the parameters before
reaching the filter line.
The new extrinsics decode only after the filter line.
These should be used instead of the old ones.

## TODO
- [x] Tests
- [x] Generate weights
- [x] Deprecation issue ->
#3771
- [x] PRDoc
- [x] Handle error in pallet-contracts

This would make writing XCMs in PJS Apps more difficult, but here's the
fix for that: polkadot-js/apps#10350.
Already deployed! https://polkadot.js.org/apps/#/utilities/xcm

Supersedes #1798

---------

Co-authored-by: PG Herveou <pgherveou@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@xlc
Copy link
Contributor

xlc commented Mar 27, 2024

Could you explain a bit more why this is necessary and if there are anything that parachain teams should be aware of so that we can check our pallets to see if similar changes are needed?

dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Apr 9, 2024
@franciscoaguirre @pgherveou
@acatangiu @dharjeezy
pallet-xcm: Deprecate execute and send in favor of execute_blob…
5cc12f1 
… and `send_blob` (paritytech#3749)

`execute` and `send` try to decode the xcm in the parameters before
reaching the filter line.
The new extrinsics decode only after the filter line.
These should be used instead of the old ones.

## TODO
- [x] Tests
- [x] Generate weights
- [x] Deprecation issue ->
paritytech#3771
- [x] PRDoc
- [x] Handle error in pallet-contracts

This would make writing XCMs in PJS Apps more difficult, but here's the
fix for that: polkadot-js/apps#10350.
Already deployed! https://polkadot.js.org/apps/#/utilities/xcm

Supersedes paritytech#1798

---------

Co-authored-by: PG Herveou <pgherveou@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@xlc
Copy link
Contributor

xlc commented Apr 12, 2024

I would like to get this out to reduce the impact to DX #4092

@xlc xlc mentioned this issue Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciscoaguirre franciscoaguirre

Labels
T13-deprecation The current issue/pr is, or should be, part of a deprecation process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xlc @franciscoaguirre