Deprecate pallet-xcm send and execute in favor of new ones #1798

franciscoaguirre · 2023-10-05T10:36:08Z

Description

This PR starts the deprecation process for pallet-xcm's send and execute extrinsics, in favor of new ones.

franciscoaguirre · 2023-10-06T08:43:42Z

bot bench polkadot-pallet --runtime westend --subcommand xcm --pallet pallet_xcm
bot bench polkadot-pallet --runtime rococo --subcommand xcm --pallet pallet_xcm

command-bot · 2023-10-06T08:43:47Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3891807 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-095d5775-b86c-4681-9f24-3156861ef924 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-06T08:43:52Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3891808 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-87356754-506b-4725-9c7a-f2dd464762ce to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-06T08:55:19Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3891808 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3891808/artifacts/download.

command-bot · 2023-10-06T08:55:47Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3891807 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3891807/artifacts/download.

franciscoaguirre · 2023-10-09T09:33:18Z

bot bench polkadot-pallet --runtime westend --subcommand xcm --pallet pallet_xcm
bot bench polkadot-pallet --runtime rococo --subcommand xcm --pallet pallet_xcm

command-bot · 2023-10-09T09:33:23Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907164 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-3c90c312-cdec-45fa-8fe1-654f34f0cb9c to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-09T09:33:28Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907165 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-0a53e18b-42b3-4b93-b928-395c8b6cf7e7 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-09T09:45:06Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907164 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907164/artifacts/download.

command-bot · 2023-10-09T09:45:28Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907165 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907165/artifacts/download.

franciscoaguirre · 2023-10-09T09:56:22Z

bot bench polkadot-pallet --runtime westend --subcommand xcm --pallet pallet_xcm
bot bench polkadot-pallet --runtime rococo --subcommand xcm --pallet pallet_xcm

command-bot · 2023-10-09T09:56:27Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907686 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-1911bd28-62ae-4053-8e42-43d4f5e9e081 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-09T09:56:32Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907687 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-8e48b674-5fe4-4c88-a694-cad3ce38036b to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-09T10:08:10Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907686 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907686/artifacts/download.

command-bot · 2023-10-09T10:08:34Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907687 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3907687/artifacts/download.

franciscoaguirre · 2023-10-10T09:52:14Z

bot bench polkadot-pallet --runtime westend --subcommand xcm --pallet pallet_xcm
bot bench polkadot-pallet --runtime rococo --subcommand xcm --pallet pallet_xcm

command-bot · 2023-10-10T09:52:19Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3920591 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-7ad6e5c8-fcd4-41de-8431-edc0e362d4b3 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-10T09:52:24Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3920592 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 14-df8db687-a239-4775-980a-e847a8ae799d to cancel this command or bot cancel to cancel all commands in this pull request.

girazoki · 2023-10-10T10:03:19Z

What is the reason behind deprecating the old extrinsics? Putting the encoded blob makes it a bit harder to use from tools like polkadot-js apps

command-bot · 2023-10-10T10:35:26Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3920591 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3920591/artifacts/download.

command-bot · 2023-10-10T10:35:53Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3920592 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3920592/artifacts/download.

…stend --target_dir=polkadot --pallet=pallet_xcm

command-bot · 2023-10-12T09:20:40Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3945226 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3945226/artifacts/download.

franciscoaguirre · 2023-10-12T09:25:33Z

bot bench polkadot-pallet --runtime westend --pallet pallet_xcm

command-bot · 2023-10-12T09:25:38Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3946535 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=westend --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 32-8a7986f7-65b2-45f5-bc9e-3def9e9ca78d to cancel this command or bot cancel to cancel all commands in this pull request.

…e=westend --target_dir=polkadot --pallet=pallet_xcm

command-bot · 2023-10-12T10:04:22Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=westend --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3946535 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3946535/artifacts/download.

franciscoaguirre · 2023-10-12T13:25:50Z

bot bench polkadot-pallet --runtime rococo --pallet pallet_xcm

command-bot · 2023-10-12T13:25:54Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3950317 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 34-e94b68e1-c5cb-48f8-a8be-26d47407209c to cancel this command or bot cancel to cancel all commands in this pull request.

…e=rococo --target_dir=polkadot --pallet=pallet_xcm

command-bot · 2023-10-12T14:04:03Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3950317 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3950317/artifacts/download.

franciscoaguirre · 2023-10-12T15:38:41Z

bot help

command-bot · 2023-10-12T15:38:44Z

Here's a link to docs

franciscoaguirre · 2023-10-12T15:42:17Z

bot bench cumulus-assets --runtime asset-hub-westend --pallet pallet_xcm

command-bot · 2023-10-12T15:42:22Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3951419 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 35-0425af8f-1ad6-4c23-8cfe-e1f39528d2f5 to cancel this command or bot cancel to cancel all commands in this pull request.

…=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm

command-bot · 2023-10-12T17:12:00Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3951419 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3951419/artifacts/download.

franciscoaguirre · 2023-10-13T16:04:41Z

bot bench cumulus-assets --runtime asset-hub-kusama --pallet pallet_xcm

command-bot · 2023-10-13T16:04:45Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3957299 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 37-171c0ab1-1794-4040-b156-52a24394b658 to cancel this command or bot cancel to cancel all commands in this pull request.

…=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm

command-bot · 2023-10-13T17:21:28Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3957299 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3957299/artifacts/download.

franciscoaguirre · 2024-03-19T19:40:21Z

Closing in favor of #3749

… and `send_blob` (#3749) `execute` and `send` try to decode the xcm in the parameters before reaching the filter line. The new extrinsics decode only after the filter line. These should be used instead of the old ones. ## TODO - [x] Tests - [x] Generate weights - [x] Deprecation issue -> #3771 - [x] PRDoc - [x] Handle error in pallet-contracts This would make writing XCMs in PJS Apps more difficult, but here's the fix for that: polkadot-js/apps#10350. Already deployed! https://polkadot.js.org/apps/#/utilities/xcm Supersedes #1798 --------- Co-authored-by: PG Herveou <pgherveou@gmail.com> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io>

… and `send_blob` (paritytech#3749) `execute` and `send` try to decode the xcm in the parameters before reaching the filter line. The new extrinsics decode only after the filter line. These should be used instead of the old ones. ## TODO - [x] Tests - [x] Generate weights - [x] Deprecation issue -> paritytech#3771 - [x] PRDoc - [x] Handle error in pallet-contracts This would make writing XCMs in PJS Apps more difficult, but here's the fix for that: polkadot-js/apps#10350. Already deployed! https://polkadot.js.org/apps/#/utilities/xcm Supersedes paritytech#1798 --------- Co-authored-by: PG Herveou <pgherveou@gmail.com> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io>

Deprecate pallet-xcm send and execute in favor of new ones

4a58f28

franciscoaguirre requested review from KiChjang, juangirini and liamaharon October 5, 2023 10:36

Some renaming

ce686e1

Finish rename

ffb7bc1

Bounded vec in benchmarks

1a997fc

Add todos for new benchmarks

d90239e

More todos

0ed6d9f

".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=we…

14c8cf1

…stend --target_dir=polkadot --pallet=pallet_xcm

".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtim…

0ca33bd

…e=westend --target_dir=polkadot --pallet=pallet_xcm

franciscoaguirre and others added 2 commits October 12, 2023 15:26

Merge branch 'master' into cis-pallet-xcm-extrinsics

f138efc

".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtim…

cd0110e

…e=rococo --target_dir=polkadot --pallet=pallet_xcm

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

b0e39e2

…=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm

franciscoaguirre and others added 2 commits October 13, 2023 18:04

Merge branch 'master' into cis-pallet-xcm-extrinsics

5ebcbe8

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

5f3a504

…=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm

serban300 mentioned this pull request Mar 12, 2024

Add XCM encoder utility polkadot-js/apps#10350

Merged

franciscoaguirre mentioned this pull request Mar 19, 2024

pallet-xcm: Deprecate execute and send in favor of execute_blob and send_blob #3749

Merged

5 tasks

franciscoaguirre closed this Mar 19, 2024

franciscoaguirre deleted the cis-pallet-xcm-extrinsics branch March 19, 2024 19:40

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024

also ignore the base xcm crate (paritytech#1798)

97eccaa

Deprecate pallet-xcm send and execute in favor of new ones #1798

Deprecate pallet-xcm send and execute in favor of new ones #1798

Conversation

franciscoaguirre commented Oct 5, 2023

Description

franciscoaguirre commented Oct 6, 2023

command-bot bot commented Oct 6, 2023 • edited Loading

command-bot bot commented Oct 6, 2023 • edited Loading

command-bot bot commented Oct 6, 2023

command-bot bot commented Oct 6, 2023

franciscoaguirre commented Oct 9, 2023

command-bot bot commented Oct 9, 2023 • edited Loading

command-bot bot commented Oct 9, 2023 • edited Loading

command-bot bot commented Oct 9, 2023

command-bot bot commented Oct 9, 2023

franciscoaguirre commented Oct 9, 2023

command-bot bot commented Oct 9, 2023 • edited Loading

command-bot bot commented Oct 9, 2023 • edited Loading

command-bot bot commented Oct 9, 2023

command-bot bot commented Oct 9, 2023

franciscoaguirre commented Oct 10, 2023

command-bot bot commented Oct 10, 2023 • edited Loading

command-bot bot commented Oct 10, 2023 • edited Loading

girazoki commented Oct 10, 2023

command-bot bot commented Oct 10, 2023

command-bot bot commented Oct 10, 2023

command-bot bot commented Oct 12, 2023

franciscoaguirre commented Oct 12, 2023

command-bot bot commented Oct 12, 2023 • edited Loading

command-bot bot commented Oct 12, 2023

franciscoaguirre commented Oct 12, 2023

command-bot bot commented Oct 12, 2023 • edited Loading

command-bot bot commented Oct 12, 2023

franciscoaguirre commented Oct 12, 2023

command-bot bot commented Oct 12, 2023

franciscoaguirre commented Oct 12, 2023

command-bot bot commented Oct 12, 2023 • edited Loading

command-bot bot commented Oct 12, 2023

franciscoaguirre commented Oct 13, 2023

command-bot bot commented Oct 13, 2023 • edited Loading

command-bot bot commented Oct 13, 2023

franciscoaguirre commented Mar 19, 2024

command-bot bot commented Oct 6, 2023 •

edited

Loading

command-bot bot commented Oct 6, 2023 •

edited

Loading

command-bot bot commented Oct 9, 2023 •

edited

Loading

command-bot bot commented Oct 9, 2023 •

edited

Loading

command-bot bot commented Oct 9, 2023 •

edited

Loading

command-bot bot commented Oct 9, 2023 •

edited

Loading

command-bot bot commented Oct 10, 2023 •

edited

Loading

command-bot bot commented Oct 10, 2023 •

edited

Loading

command-bot bot commented Oct 12, 2023 •

edited

Loading

command-bot bot commented Oct 12, 2023 •

edited

Loading

command-bot bot commented Oct 12, 2023 •

edited

Loading

command-bot bot commented Oct 13, 2023 •

edited

Loading