Missing Official Repository in DockerHub

[nijel]

The docker image marked as public at:
https://hub.docker.com/r/phpmyadmin/phpmyadmin/
There is a process that will mark the image as official, more information:
https://docs.docker.com/docker-hub/official_repos/
example of official repositories:
https://hub.docker.com/_/wordpress/
https://hub.docker.com/_/drupal/
it appears that official repos has some security benefits (apart from distinguish from other public repos) such as content trust (see issue: not signed docker image) enabled by docker itself.

fix:
do the needed changes (there is a guideline), and apply for official repositories at DockerHub.

Reported by Emanuel Bronshtein.

[emanuelb]

Semi related, there is new program called Docker Store:
https://success.docker.com/Store
which has guidelines under "Tips for becoming a publisher:"
https://blog.docker.com/2016/06/docker-store/
currently PHPMyAdmin docker listed under community:
https://store.docker.com/community/images/phpmyadmin/phpmyadmin

[J0WI]

I think #51 is one of the major changes that need to be done for this.
I stumbled over a few big changes while playing around with multiple base images:

• the etc/php.ini is very confusing. All comments and default values should be removed. The custom values can be copied to /usr/local/etc/php/conf.d/php-phpmyadmin.ini
• default values like the upload limit should not be changed (see discussion in Increase PHP file upload limit docker-library/wordpress#10) (Cleanup php.ini #221)
• allow custom commands (Run supervisord in CMD #174)
• use default /var/www/html root (Drop custom user/group and document root, change permissions on runtime #198)
• handle source copy/directory permissions in entrypoint (Drop custom user/group and document root, change permissions on runtime #198)
• same for php-fpm.conf(remove it entirely?) (Drop custom user/group and document root, change permissions on runtime #198)
• user/group nobody is problematic, what's wrong with www/www-data? (Drop custom user/group and document root, change permissions on runtime #198)

Afterwards:

• test should be moved here
• docs and examples should be moved here
• request inclusion into the docker-library

Let me know what you think about this!

[nijel]

My feedback on this is: patches welcome. We really do not have anybody in the team interested in the docker and this is really best effort image I could create with my almost zero Docker knowledge...

[J0WI]

I've added #168 but #169 should be considered first.

[J0WI]

Do you care about backwards compatibility or will current users just be migrated to the new apache based image?

[J0WI]

After messing around with permissions I finally submitted #198.
So the last step is removing nginx and supervisord from this image and using upstream apache/nginx 🎉

[J0WI]

@nijel @ibennetch @williamdes
I think this is nearly done. But the inclusion request @docker-library can only be done with the support of a representative of @phpmyadmin:
https://github.com/docker-library/official-images/blob/master/NEW-IMAGE-CHECKLIST.md

[J0WI]

@ibennetch would be great if you could fix the automated builds on DockerHub. The current image variants are not built and there are already some pending security updates for PHP and its dependencies.

[nijel]

I've fixed wesite/CDN integration to fix build of daily snapshots. I've also pushed new tag to rebuild stable release.

[J0WI]

The tags should be updated as described here:
https://github.com/phpmyadmin/docker/pull/216/files#diff-04c6e90faac2675aa89e2176d2eec7d8

[williamdes]

@J0WI
test should be moved here
docs and examples should be moved here

Is this only files moving in our repo or a PR to docker is needed ?

[J0WI]

A PR to docker is needed for all further steps.

[J0WI]

I think this is nearly done. But the inclusion request @docker-library can only be done with the support of a representative of @phpmyadmin:
https://github.com/docker-library/official-images/blob/master/NEW-IMAGE-CHECKLIST.md

🏓 @williamdes @ibennetch

[williamdes]

@J0WI do you want to open the documentation PR and I open the library one ?

[J0WI]

Sure!
You just have to pipe the output of generate-stackbrew-library.sh in official-images/library/phpmyadmin for the library.

[williamdes]

I will close this issue when everything is online, sorry for the open-close noise

[williamdes]

"test should be moved here"
@J0WI is a PR needed ?

[J0WI]

I think this does not make much sense now. This depends on docker-library/official-images#7288, otherwise they will just fail.

[J0WI]

This is finally done: https://hub.docker.com/_/phpmyadmin 🎉