-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use upstream PHP FPM Alpine Docker image #144
Conversation
It fails to test as the test setup relies on using more recent apline (the PHP images are based on 3.4, while we were on 3.6). That also pops up question whether it's better to stick with maintained alpine image having current all libs or maintained PHP image which has current PHP, but everything else is older. Do you know if Alpine 3.4 still receives security fixes? |
I don't know why the tests are failing. Both versions build and run. |
I don't see anything obvious, but apparently the container behaves differently than the original one. The problem can be seen here - the test script is not found. Maybe the working directory is different than it used to be and that confuses the script lookup: Lines 72 to 76 in f5644c5
|
Thanks, I've updated the path in the tests. |
@nijel would be great to get some feedback here.
|
testing/test-docker.sh
Outdated
if [ -f ./phpmyadmin_test.py ] ; then | ||
FILENAME=./phpmyadmin_test.py | ||
if [ -f /phpmyadmin_test.py ] ; then | ||
FILENAME=/phpmyadmin_test.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably both variants should stay to allow local testing.
I've re-added the old condition. |
Issue #144 Signed-off-by: Michal Čihař <michal@cihar.com>
Issue #144 Signed-off-by: Michal Čihař <michal@cihar.com>
This switches the base to the upstream PHP FPM Alpine Docker image, so we can benefit from the maintenance there.
I included and configured the same php extensions as before.
This might be a dependency task of #56.