-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terror: provide a RegisterFinish API #1352
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: kennytm <kennytm@gmail.com>
My main point is actually here pingcap/tidb#25405 (comment)
We have got stuck on the error before, and fixed it then. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bd914f4
|
What problem does this PR solve?
Prevent regression like pingcap/tidb#28190
What is changed and how it works?
TiDB will register all the error kinds in its initialization, and then call this API
After that, misuse of the terror will panic, thus the bug is exposed early.
Check List
Tests
In TiDB
Code changes