Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, executor: fix test race in terror #25405

Merged
merged 3 commits into from
Jun 15, 2021
Merged

ddl, executor: fix test race in terror #25405

merged 3 commits into from
Jun 15, 2021

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jun 15, 2021

What problem does this PR solve?

Issue Number: close #25393

Problem Summary:

NewStdErr is NOT thread-safe and need be used in init phase

What is changed and how it works?

Proposal: xxx

What's Changed, How it Works:

tiny fix...move to init phase

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

  • n/a

Release note

  • No release note

@lysu lysu requested a review from a team as a code owner June 15, 2021 03:38
@lysu lysu requested review from lzmhhh123 and removed request for a team June 15, 2021 03:38
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 15, 2021
@lysu lysu removed the request for review from lzmhhh123 June 15, 2021 03:38
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jun 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2021
@tiancaiamao
Copy link
Contributor

Is there some way to prevent this kind of error in the future?
Maybe nobody read the document and maybe people still make this kind of mistakes in the future.

@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c38e485

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2021
@ti-chi-bot ti-chi-bot merged commit 9321489 into pingcap:master Jun 15, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2021
@lysu @ti-srebot
cherry pick pingcap#25405 to release-5.1
d95c7d4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25409

ti-chi-bot pushed a commit that referenced this pull request Jun 15, 2021
@ti-srebot
ddl, executor: fix test race in terror (#25405) (#25409)
685d4c8
@xiongjiwei xiongjiwei mentioned this pull request Jun 15, 2021
Closed
@ichn-hu ichn-hu mentioned this pull request Sep 18, 2021
Closed
@ichn-hu
Copy link
Contributor

ichn-hu commented Sep 18, 2021

/run-cherry-pick

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 18, 2021
@lysu @ti-srebot
cherry pick pingcap#25405 to release-4.0
50fe9e5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 18, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #28197

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 18, 2021
@lysu @ti-srebot
cherry pick pingcap#25405 to release-5.0
f62b144 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 18, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #28198

ti-chi-bot pushed a commit that referenced this pull request Sep 18, 2021
@ti-srebot
ddl, executor: fix test race in terror (#25405) (#28198)
560b0da
windtalker added a commit to ti-srebot/tidb that referenced this pull request Sep 26, 2021
@windtalker
Revert "ddl, executor: fix test race in terror (pingcap#25405) (pingc…
08296d0 
…ap#28198)"

This reverts commit 560b0da.
windtalker added a commit to ti-srebot/tidb that referenced this pull request Sep 26, 2021
@windtalker
Revert "ddl, executor: fix test race in terror (pingcap#25405) (pingc…
4b958a1 
…ap#28198)"

This reverts commit 560b0da.
windtalker added a commit to ti-srebot/tidb that referenced this pull request Sep 26, 2021
@windtalker
Revert "ddl, executor: fix test race in terror (pingcap#25405) (pingc…
d844db0 
…ap#28198)"

This reverts commit 560b0da.
zhouqiang-cl pushed a commit that referenced this pull request Sep 26, 2021
@windtalker
planner/core: cherry pick #28251 to release-5.0-20210923 (#28344)
5bda4a8 
* ddl, executor: fix test race in terror (#25405) (#28198)

* cherry pick #28251 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
zhouqiang-cl pushed a commit that referenced this pull request Sep 26, 2021
@windtalker
copr: cherry pick #28201 to release-5.0-20210923 (#28341)
b917170 
* ddl, executor: fix test race in terror (#25405) (#28198)

* cherry pick #28201 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
zhouqiang-cl pushed a commit that referenced this pull request Sep 26, 2021
@windtalker
sessionctx: cherry pick #28022 to release-5.0-20210923 (#28343)
30d18b9 
* ddl, executor: fix test race in terror (#25405) (#28198)

* cherry pick #28022 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ichn-hu ichn-hu linked an issue Sep 27, 2021 that may be closed by this pull request
tidb paniced on concurrent inserting invalid value #28190
Closed
@ichn-hu ichn-hu removed a link to an issue Sep 27, 2021
tidb paniced on concurrent inserting invalid value #28190
Closed
@tiancaiamao tiancaiamao mentioned this pull request Sep 30, 2021
Merged
@ti-srebot ti-srebot mentioned this pull request Oct 12, 2021
Closed
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 12, 2021
@lysu @ti-srebot
cherry pick pingcap#25405 to release-5.2
d54aa4c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #28750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@xhebox xhebox xhebox approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
component/test needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data race in TestClusteredIndexSyntax
7 participants
@lysu @ti-chi-bot @tiancaiamao @ti-srebot @ichn-hu @xhebox @zimulala