Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, executor: fix test race in terror (#25405) #28198

Merged
merged 7 commits into from
Sep 18, 2021
Merged

ddl, executor: fix test race in terror (#25405) #28198

merged 7 commits into from
Sep 18, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 18, 2021 •
edited by ichn-hu
Loading

cherry-pick #25405 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/28198

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/28198:release-5.0-9321489621f6

What problem does this PR solve?

Issue Number: close #25393

Problem Summary:

NewStdErr is NOT thread-safe and need be used in init phase

What is changed and how it works?

Proposal: xxx

What's Changed, How it Works:

tiny fix...move to init phase

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

  • n/a

Release note

  • Fixed a bug that causes TiDB panic when inserting invalid date value concurrently.

@lysu @ti-srebot
cherry pick pingcap#25405 to release-5.0
f62b144 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 18, 2021
@ti-srebot ti-srebot mentioned this pull request Sep 18, 2021
Merged
@ti-srebot ti-srebot added component/test sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick labels Sep 18, 2021
@ti-srebot ti-srebot added this to the v5.0.4 milestone Sep 18, 2021
@ti-chi-bot ti-chi-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2021
@ti-srebot
Copy link
Contributor Author

@lysu you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2021
@ichn-hu
Copy link
Contributor

ichn-hu commented Sep 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2afa9f152cb2459111744fb8704ebd9c470edc40

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2021
@ichn-hu
Copy link
Contributor

ichn-hu commented Sep 18, 2021

close #28190

@ichn-hu ichn-hu linked an issue Sep 18, 2021 that may be closed by this pull request
tidb paniced on concurrent inserting invalid value #28190
Closed
@zhouqiang-cl zhouqiang-cl removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 18, 2021
@zhouqiang-cl
Copy link
Contributor

/run-check_dev

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2021
@ichn-hu
Copy link
Contributor

ichn-hu commented Sep 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 12b8988

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2021
@ti-chi-bot ti-chi-bot merged commit 560b0da into pingcap:release-5.0 Sep 18, 2021
windtalker added a commit to ti-srebot/tidb that referenced this pull request Sep 26, 2021
@windtalker
Revert "ddl, executor: fix test race in terror (pingcap#25405) (pingc…
08296d0 
…ap#28198)"

This reverts commit 560b0da.
windtalker added a commit to ti-srebot/tidb that referenced this pull request Sep 26, 2021
@windtalker
Revert "ddl, executor: fix test race in terror (pingcap#25405) (pingc…
4b958a1 
…ap#28198)"

This reverts commit 560b0da.
windtalker added a commit to ti-srebot/tidb that referenced this pull request Sep 26, 2021
@windtalker
Revert "ddl, executor: fix test race in terror (pingcap#25405) (pingc…
d844db0 
…ap#28198)"

This reverts commit 560b0da.
zhouqiang-cl pushed a commit that referenced this pull request Sep 26, 2021
@windtalker
planner/core: cherry pick #28251 to release-5.0-20210923 (#28344)
5bda4a8 
* ddl, executor: fix test race in terror (#25405) (#28198)

* cherry pick #28251 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
zhouqiang-cl pushed a commit that referenced this pull request Sep 26, 2021
@windtalker
copr: cherry pick #28201 to release-5.0-20210923 (#28341)
b917170 
* ddl, executor: fix test race in terror (#25405) (#28198)

* cherry pick #28201 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
zhouqiang-cl pushed a commit that referenced this pull request Sep 26, 2021
@windtalker
sessionctx: cherry pick #28022 to release-5.0-20210923 (#28343)
30d18b9 
* ddl, executor: fix test race in terror (#25405) (#28198)

* cherry pick #28022 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.4, v5.0.6 Dec 21, 2021
@XuHuaiyu XuHuaiyu mentioned this pull request Dec 22, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@xhebox xhebox xhebox approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees

@lysu lysu

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/test sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.6
Development

Successfully merging this pull request may close these issues.

tidb paniced on concurrent inserting invalid value
7 participants
@ti-srebot @ti-chi-bot @ichn-hu @zhouqiang-cl @tiancaiamao @xhebox @lysu