Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs #581

Merged
merged 2 commits into from
Oct 18, 2019
Merged

remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs #581

merged 2 commits into from
Oct 18, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Oct 17, 2019

What problem does this PR solve?

for pingcap/tidb#12330

What is changed and how it works?

remove GrantPriv from AllGlobalPrivs, AllDBPrivs, AllTablePrivs

Check List

@tsthght tsthght requested a review from a team October 17, 2019 01:13
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tiancaiamao
Copy link
Collaborator

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Oct 18, 2019
kennytm
kennytm approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Oct 18, 2019
@kennytm kennytm merged commit 448f044 into pingcap:master Oct 18, 2019
@cfzjywxk cfzjywxk mentioned this pull request Oct 18, 2019
Merged
@AilinKid
Copy link
Contributor

AilinKid commented Oct 21, 2019 •
edited
Loading

should we modify c.Assert(len(mysql.Priv2UserCol), Equals, len(mysql.AllGlobalPrivs)) in privilege_test.go to pass the build-integration CI here? @kennytm

@kennytm
Copy link
Contributor

kennytm commented Oct 21, 2019

@AilinKid Yes you're supposed to follow up on the TiDB repository to update the test cases given the latest parser.

@ekalinin ekalinin mentioned this pull request Oct 21, 2019
Merged
@ekalinin
Copy link
Contributor

Fixed tests here:

imtbkcat pushed a commit to imtbkcat/parser that referenced this pull request Dec 6, 2019
@tsthght
remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs (pingca…
435d97c 
…p#581)
@imtbkcat imtbkcat mentioned this pull request Dec 6, 2019
Merged
jackysp pushed a commit that referenced this pull request Dec 9, 2019
@jackysp
remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs (#581) (#…
9504797 
…665)
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@tsthght @kennytm
remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs (pingca…
7b3b3d9 
…p#581)

* remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs

* handle testcase error
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@tsthght @kennytm
remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs (pingca…
d8d367a 
…p#581)

* remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs

* handle testcase error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tsthght @CLAassistant @tiancaiamao @AilinKid @kennytm @ekalinin @you06