executor: fix inconsistent of grants privileges with MySQL when executing grant all on ...
#12330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsthght
changed the title
grant all on ...
|
@tsthght Please fix test below: And add some test to test |
Codecov Report
@@ Coverage Diff @@
## master #12330 +/- ##
===========================================
Coverage 80.0356% 80.0356%
===========================================
Files 465 465
Lines 107136 107136
===========================================
Hits 85747 85747
Misses 14951 14951
Partials 6438 6438 |
|
/rebuild |
|
/run-unit-test |
imtbkcat
reviewed
Sep 25, 2019
|
Any update? @tsthght |
It will be updated today. |
tiancaiamao
reviewed
Oct 17, 2019
|
You can use |
Great! Thank you, I will try it~ |
tiancaiamao
reviewed
Oct 18, 2019
|
/run-all-tests |
|
/run-all-tests |
|
/run-integration-common-test tidb-test=pr/926 |
|
/run-all-tests tidb-test=pr/926 |
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/926 |
|
I will approve after test merge, wait a moment. |
|
LGTM |
|
/run-all-tests tidb-test=pr/926 |
lfkdsk
added a commit
to JustProject/tidb
that referenced
this pull request
Oct 26, 2019
…ect/tidb into feature-add-udf-support * 'feature-add-udf-support' of https://github.com/JustProject/tidb: (26 commits) *: fix bug that the kill command doesn't work when the killed session is waiting for the pessimistic lock (pingcap#12852) executor: fix the projection upon the indexLookUp in indexLookUpJoin can't get result. (pingcap#12889) planner, executor: support create view on union (pingcap#12595) planner/cascades: introduce TransformationID in cascades planner (pingcap#12879) executor: fix data race in test (pingcap#12910) executor: reuse chunk row for insert on duplicate update (pingcap#12847) ddl: speed up tests (pingcap#12888) executor: speed up test (pingcap#12896) expression: implement vectorized evaluation for `builtinSecondSig` (pingcap#12886) expression: implement vectorized evaluation for `builtinJSONObjectSig` (pingcap#12663) expression: speed up builtinRepeatSig by using MergeNulls (pingcap#12674) expression: speed up unit tests under the expression package (pingcap#12887) store,kv: snapshot doesn't cache the non-exists kv entries lead to poor 'insert ignore' performance (pingcap#12872) executor: fix data race in `GetDirtyTable()` (pingcap#12767) domain: increase TTL to reduce the occurrence of reporting min startTS errors (pingcap#12578) executor: split test for speed up (pingcap#12881) executor: fix inconsistent of grants privileges with MySQL when executing `grant all on ...` (pingcap#12330) expression: implement vectorized evaluation for `builtinJSONUnquoteSig` (pingcap#12841) tune grpc connection count between tidb and tikv (pingcap#12884) Makefile: change test parallel to 8 (pingcap#12885) ...
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Dec 9, 2019
…ting `grant all on ...` (pingcap#12330)
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
…ting `grant all on ...` (pingcap#12330)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
1 fix bug for #12324
2 fix bug for execute SQL
show grants for xxxWhat is changed and how it works?
create user "ght1";
grant all on . to 'ght1'@'%' identified by 'Poiuy123';
select * from mysql.user where user='ght1'\G
*************************** 1. row ***************************
Grant_priv: N
Check List
Tests