stats: add metircs for high error rate feedback (#9209)

pingcap · Feb 12, 2019 · 8431d11 · 8431d11
1 parent 347c852
commit 8431d11
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/metrics/metrics.go b/metrics/metrics.go
@@ -74,6 +74,7 @@ func RegisterMetrics() {
 	prometheus.MustRegister(GetTokenDurationHistogram)
 	prometheus.MustRegister(HandShakeErrorCounter)
 	prometheus.MustRegister(HandleJobHistogram)
+	prometheus.MustRegister(SignificantFeedbackCounter)
 	prometheus.MustRegister(JobsGauge)
 	prometheus.MustRegister(KeepAliveCounter)
 	prometheus.MustRegister(LoadPrivilegeCounter)

diff --git a/metrics/stats.go b/metrics/stats.go
@@ -76,4 +76,12 @@ var (
 			Name:      "store_query_feedback_total",
 			Help:      "Counter of storing query feedback.",
 		}, []string{LblType})
+
+	SignificantFeedbackCounter = prometheus.NewCounter(
+		prometheus.CounterOpts{
+			Namespace: "tidb",
+			Subsystem: "statistics",
+			Name:      "high_error_rate_feedback_total",
+			Help:      "Counter of query feedback whose actual count is much different than calculated by current statistics",
+		})
 )
diff --git a/statistics/update.go b/statistics/update.go
@@ -193,8 +193,11 @@ func (s *SessionStatsCollector) StoreQueryFeedback(feedback interface{}, h *Hand
 	} else {
 		rate = math.Abs(expected-float64(q.actual)) / float64(q.actual)
 	}
-	if rate >= MinLogErrorRate && (q.actual >= MinLogScanCount || q.expected >= MinLogScanCount) && log.GetLevel() == log.DebugLevel {
-		q.logDetailedInfo(h)
+	if rate >= MinLogErrorRate && (q.actual >= MinLogScanCount || q.expected >= MinLogScanCount) {
+		metrics.SignificantFeedbackCounter.Inc()
+		if log.GetLevel() == log.DebugLevel {
+			q.logDetailedInfo(h)
+		}
 	}
 	metrics.StatsInaccuracyRate.Observe(rate)
 	s.Lock()