stats: add metircs for high error rate feedback #9209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9209 +/- ##
==========================================
+ Coverage 67.22% 67.23% +0.01%
==========================================
Files 371 371
Lines 77268 77271 +3
==========================================
+ Hits 51941 51953 +12
+ Misses 20684 20680 -4
+ Partials 4643 4638 -5
Continue to review full report at Codecov.
|
eurekaka
reviewed
Jan 29, 2019
zz-jason
reviewed
Jan 29, 2019
| q.logDetailedInfo(h) | ||
| if rate >= MinLogErrorRate && (q.actual >= MinLogScanCount || q.expected >= MinLogScanCount) { | ||
| metrics.HighErrorRateFeedBackCounter.Inc() | ||
| if log.GetLevel() == log.DebugLevel { |
There was a problem hiding this comment.
Can we change this log level to INFO or WARN?
There was a problem hiding this comment.
This part logs many things and has some heavy calculation. So it would be better to set it to debug level.
XuHuaiyu
reviewed
Jan 29, 2019
| prometheus.CounterOpts{ | ||
| Namespace: "tidb", | ||
| Subsystem: "statistics", | ||
| Name: "high_error_rate_feedback_total", |
There was a problem hiding this comment.
Should we update ansible as well?
alivxxx
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add metrics to count the case when the actual count got by feedback is much different from the expected count calculated by statistics.
Check List
Tests
Related changes
tidb-ansiblerepository